From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v1 1/7] devicetree: power: battery: Add properties for pre-charge and end-charge current Date: Tue, 28 Mar 2017 19:39:46 -0500 Message-ID: <20170329003946.3eyqmsozj2sxrtiw@rob-hp-laptop> References: <20170321220921.5834-1-liam@networkimprov.net> <20170321220921.5834-2-liam@networkimprov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170321220921.5834-2-liam-RYWXG+zxWwBdeoIcmNTgJF6hYfS7NtTn@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Liam Breck Cc: Sebastian Reichel , Tony Lindgren , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hans de Goede , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Breck List-Id: devicetree@vger.kernel.org On Tue, Mar 21, 2017 at 03:09:15PM -0700, Liam Breck wrote: > From: Liam Breck > > precharge-current-microamp and endcharge-current-microamp are used > by battery chargers at the beginning and end of a charging cycle. > > Depends-on: https://patchwork.kernel.org/patch/9633605/ > Cc: Rob Herring > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Liam Breck > --- > Documentation/devicetree/bindings/power/supply/battery.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/battery.txt b/Documentation/devicetree/bindings/power/supply/battery.txt > index 53a68c0..494374a 100644 > --- a/Documentation/devicetree/bindings/power/supply/battery.txt > +++ b/Documentation/devicetree/bindings/power/supply/battery.txt > @@ -12,6 +12,8 @@ Optional Properties: > - voltage-min-design-microvolt: drained battery voltage > - energy-full-design-microwatt-hours: battery design energy > - charge-full-design-microamp-hours: battery design capacity > + - precharge-current-microamp: current for pre-charge phase > + - endcharge-current-microamp: current for charge termination phase current is implied by microamp, so perhaps just pre-charge-microamp and end-charge-microamp. I know little about batteries, but don't you also need to know when each phase starts/ends? I mainly ask because we just added the previous properties and now we're adding 2 more. While fine to add features to a driver one by one, we really shouldn't for bindings. The h/w is not evolving (in a month). Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html