All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Dong Aisheng <dongas86@gmail.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Fugang Duan <fugang.duan@nxp.com>,
	Octavian Purdila <octavian.purdila@nxp.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
Date: Wed, 29 Mar 2017 10:57:44 +0800	[thread overview]
Message-ID: <20170329025742.GU30608@dragon> (raw)
In-Reply-To: <1490699810.3546.10.camel@nxp.com>

On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote:
> On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote:
> > Hi Leonard,
> > 
> > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> > > 
> > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> > > Add this driver to the default imx config since the device is present on
> > > one of the evaluation boards.
> > Upstream currently no evaluation board support.
> > 
> > This may leave to Shawn to decide whether apply it.
> 
> Really? But the dts for this eval board is included in upstream. Shouldn't the
> default config try to work with the default imx*.dts files included?
> 
> > > This used to work mostly fine with the generic phy driver but since
> > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> > I guess you should get a checkpatch error here.
> 
> Because I didn't reference that other commit right? Sorry about this.
> 
> Should I submit again with an improved commit message?

Yes, please, and make sure that checkpatch.pl is happy about the patch.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY
Date: Wed, 29 Mar 2017 10:57:44 +0800	[thread overview]
Message-ID: <20170329025742.GU30608@dragon> (raw)
In-Reply-To: <1490699810.3546.10.camel@nxp.com>

On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote:
> On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote:
> > Hi Leonard,
> > 
> > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote:
> > > 
> > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY.
> > > Add this driver to the default imx config since the device is present on
> > > one of the evaluation boards.
> > Upstream currently no evaluation board support.
> > 
> > This may leave to Shawn to decide whether apply it.
> 
> Really? But the dts for this eval board is included in upstream. Shouldn't the
> default config try to work with the default imx*.dts files included?
> 
> > > This used to work mostly fine with the generic phy driver but since
> > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer
> > I guess you should get a checkpatch error here.
> 
> Because I didn't reference that other commit right? Sorry about this.
> 
> Should I submit again with an improved commit message?

Yes, please, and make sure that checkpatch.pl is happy about the patch.

Shawn

  reply	other threads:[~2017-03-29  2:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 14:27 [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY Leonard Crestez
2017-03-22 14:27 ` Leonard Crestez
2017-03-22 15:28 ` Fabio Estevam
2017-03-22 15:28   ` Fabio Estevam
2017-03-22 21:09 ` Florian Fainelli
2017-03-22 21:09   ` Florian Fainelli
2017-03-23  1:17 ` Andy Duan
2017-03-23  1:17   ` Andy Duan
2017-03-24  6:43 ` Dong Aisheng
2017-03-24  6:43   ` Dong Aisheng
2017-03-28 11:16   ` Leonard Crestez
2017-03-28 11:16     ` Leonard Crestez
2017-03-29  2:57     ` Shawn Guo [this message]
2017-03-29  2:57       ` Shawn Guo
2017-03-30  6:47     ` Dong Aisheng
2017-03-30  6:47       ` Dong Aisheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170329025742.GU30608@dragon \
    --to=shawnguo@kernel.org \
    --cc=dongas86@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=fugang.duan@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=octavian.purdila@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.