From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932759AbdC2Lz1 (ORCPT ); Wed, 29 Mar 2017 07:55:27 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:40849 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932623AbdC2LzY (ORCPT ); Wed, 29 Mar 2017 07:55:24 -0400 X-AuditID: b6c32a2e-f79506d0000046c0-ce-58dba09e1fb7 From: Andi Shyti To: MyungJoo Ham , Chanwoo Choi , Jaewon Kim Cc: Seung-Woo Kim , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH 1/2] extcon: max77843: improve the code and minimize duplicated lines Date: Wed, 29 Mar 2017 20:54:52 +0900 Message-id: <20170329115453.4268-2-andi.shyti@samsung.com> X-Mailer: git-send-email 2.11.0 In-reply-to: <20170329115453.4268-1-andi.shyti@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMKsWRmVeSWpSXmKPExsWy7bCmhu68BbcjDJYe4bDYfuQZq8XiH8+Z LK5/ec5qsaPhCKvF+fMb2C0u75rDZnG7cQWbxYzJL9kcODyuL/nE7LFpVSebR9+WVYwenzfJ BbBEpdpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAJ2h pFCWmFMKFApILC5W0rezKcovLUlVyMgvLrFVijY0NNIzNDDXMzIy0jMxjrUyMgUqSUjNePd/ AWtBA1/F68//mRoY/3F1MXJySAiYSHy/dpkNwhaTuHBvPZDNxSEksJRR4s+nS8wQTjuTxPHG P+wwHVu/PmKFSCxnlLgwcTELhPORUeLQrDnMIFVsApoSTbd/gM0VEaiSWLzuG9hcZoHtjBJ3 Z29mBUkIC4RLTFt2hQXEZhFQlZjbNwtsBa+AlcTCjlYWiHXyErvaLoLVcwpYSzzZf4QJZJCE wHc2iQkz7wIlOIAcWYlNB5gh6l0kHp38AmULS7w6vgXqbGmJv0tvMUL0NjNKbNh2GWpQC6PE 75dXoUFgLHH/wT2wbmYBPone30+YIBbwSnS0CUGUeEj8P/SOFcJ2lLi59x40kPoYJR4tec4+ gVFmASPDKkax1ILi3PTUYtMCY73ixNzi0rx0veT83E2M4ASkpbeD8d8C70OMAhyMSjy8Gftu RQixJpYVV+YeYpTgYFYS4dVXvB0hxJuSWFmVWpQfX1Sak1p8iNEUGFATmaVEk/OByTGvJN7Q xNLAxNTM2MDY0MJSSZxXY+W1CCGB9MSS1OzU1ILUIpg+Jg5OqQbGmBtP3UQP3LfafNIq75WE stF1dlcNx1Td2CPnQ4yNRYryJOY/OtzBHnXh74Jsh+uupz6oFDYuK0npezrXUCttxSW+i1vm lYd63vJPmnMx4+pHi8cyay4qP7op9Pd0+p3apfLq/MtZ+D+uW/Hm3JHWjKhJKe1CN/5cNny4 WGBKTiCDxr2yyguflFiKMxINtZiLihMBTjHdYFYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t9jAd25C25HGDzoZLPYfuQZq8XiH8+Z LK5/ec5qsaPhCKvF+fMb2C0u75rDZnG7cQWbxYzJL9kcODyuL/nE7LFpVSebR9+WVYwenzfJ BbBEudlkpCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5RgZowME5 wD1YSd8uwS3j3f8FrAUNfBWvP/9namD8x9XFyMkhIWAisfXrI1YIW0ziwr31bF2MXBxCAksZ JTbdbmKCcD4yStze/ZwNpIpNQFOi6fYPMFtEoEri5P7njCBFzALbGSW2vmpnBkkIC4RLHNlw hhHEZhFQlZjbN4sdxOYVsJJY2NHKArFOXmJX20Ww1ZwC1hJP9h9hArGFgGpu/d3MPIGRdwEj wypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4LB+Jr2D8fAu90OMAhyMSjy8O/JuRQix JpYVV+YeYpTgYFYS4dVXvB0hxJuSWFmVWpQfX1Sak1p8iNEU6LCJzFKiyfnAmMsriTc0MTcx NzawMLe0NDFSEudtnP0sXEggPbEkNTs1tSC1CKaPiYNTqoGRXUT85M7m5AvruD/KWdhf2rpN Rz3PXWRBvX6A9jSjj+wXfPb6iMzUTrk507ht15aopiTHW53ei/VzYk9JKi0+afRF9dXGubXT 8tNmH0sLKnB7/nyC7dfK2yIvFyvE/TJe7LpjUdmig+77z+Xr+f1RsV90bLGysZ+wjGJjiM9v 1dkXVgVGimorsRRnJBpqMRcVJwIA6jzREIECAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170329115509epcas5p14fddb50b71177529674457026a743c61 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7JWI65SUG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLzthLAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?QW5kaSBTaHl0aRtUaXplbiBQbGF0Zm9ybSBMYWIuG1NhbXN1?= =?UTF-8?B?bmcgRWxlY3Ryb25pY3MbU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170329115509epcas5p14fddb50b71177529674457026a743c61 X-RootMTR: 20170329115509epcas5p14fddb50b71177529674457026a743c61 References: <20170329115453.4268-1-andi.shyti@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Andi Shyti --- drivers/extcon/extcon-max77843.c | 33 ++++++++------------------------- 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c index 6e722d552cf1..fcdabc4b4025 100644 --- a/drivers/extcon/extcon-max77843.c +++ b/drivers/extcon/extcon-max77843.c @@ -264,37 +264,20 @@ static int max77843_muic_get_cable_type(struct max77843_muic_info *info, chg_type = info->status[MAX77843_MUIC_STATUS2] & MAX77843_MUIC_STATUS2_CHGTYP_MASK; - /* Check GROUND accessory with charger cable */ - if (adc == MAX77843_MUIC_ADC_GROUND) { - if (chg_type == MAX77843_MUIC_CHG_NONE) { - /* - * The following state when charger cable is - * disconnected but the GROUND accessory still - * connected. - */ - *attached = false; - cable_type = info->prev_chg_type; - info->prev_chg_type = MAX77843_MUIC_CHG_NONE; - } else { - - /* - * The following state when charger cable is - * connected on the GROUND accessory. - */ - *attached = true; - cable_type = MAX77843_MUIC_CHG_GND; - info->prev_chg_type = MAX77843_MUIC_CHG_GND; - } - break; - } - if (chg_type == MAX77843_MUIC_CHG_NONE) { *attached = false; cable_type = info->prev_chg_type; info->prev_chg_type = MAX77843_MUIC_CHG_NONE; } else { *attached = true; - cable_type = info->prev_chg_type = chg_type; + switch (adc) { + case MAX77843_MUIC_ADC_GROUND: + info->prev_chg_type = MAX77843_MUIC_CHG_GND; + break; + default: + info->prev_chg_type = chg_type; + } + cable_type = info->prev_chg_type; } break; case MAX77843_CABLE_GROUP_ADC_GND: -- 2.11.0