All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel.vetter@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v4 11/11] drm/rockchip: Remove unnecessary NULL check
Date: Wed, 29 Mar 2017 16:44:01 +0200	[thread overview]
Message-ID: <20170329144401.1804-12-thierry.reding@gmail.com> (raw)
In-Reply-To: <20170329144401.1804-1-thierry.reding@gmail.com>

From: Thierry Reding <treding@nvidia.com>

The expression &private->fbdev_helper can never be NULL, so the check is
completely unnecessary.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index 81f9548672b0..df6bceabeca8 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
@@ -168,10 +168,8 @@ rockchip_user_fb_create(struct drm_device *dev, struct drm_file *file_priv,
 static void rockchip_drm_output_poll_changed(struct drm_device *dev)
 {
 	struct rockchip_drm_private *private = dev->dev_private;
-	struct drm_fb_helper *fb_helper = &private->fbdev_helper;
 
-	if (fb_helper)
-		drm_fb_helper_hotplug_event(fb_helper);
+	drm_fb_helper_hotplug_event(&private->fbdev_helper);
 }
 
 static void
-- 
2.12.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-03-29 14:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170329144416epcas3p471b0fac16a5bb6b51a3abf012c9e9e92@epcas3p4.samsung.com>
2017-03-29 14:43 ` [PATCH v4 00/11] drm/fb-helper: Deferred setup support Thierry Reding
2017-03-29 14:43   ` [PATCH v4 01/11] drm/fb-helper: Cleanup checkpatch warnings Thierry Reding
2017-03-29 14:43   ` [PATCH v4 02/11] drm/fb-helper: Reshuffle code for subsequent patches Thierry Reding
2017-03-29 14:43   ` [PATCH v4 03/11] drm/fb-helper: Improve code readability Thierry Reding
2017-03-29 14:43   ` [PATCH v4 04/11] drm/fb-helper: Push down modeset lock into FB helpers Thierry Reding
2017-03-31 18:28     ` Daniel Vetter
2017-03-29 14:43   ` [PATCH v4 05/11] drm/fb-helper: Add top-level lock Thierry Reding
2017-03-29 14:43   ` [PATCH v4 06/11] drm/fb-helper: Make top-level lock more robust Thierry Reding
2017-03-29 14:51     ` Thierry Reding
2017-04-03  8:40     ` [Intel-gfx] " Daniel Vetter
2017-03-29 14:43   ` [PATCH v4 07/11] drm/fb-helper: Support deferred setup Thierry Reding
2017-03-29 14:43   ` [PATCH v4 08/11] drm/exynos: Remove custom FB helper " Thierry Reding
2017-03-29 17:50     ` Daniel Vetter
2017-03-29 14:43   ` [PATCH v4 09/11] drm/hisilicon: " Thierry Reding
2017-03-29 14:44   ` [PATCH v4 10/11] drm/atmel-hlcdc: Remove unnecessary NULL check Thierry Reding
2017-03-29 14:44   ` Thierry Reding [this message]
2017-06-21 13:39     ` [PATCH v4 11/11] drm/rockchip: " Daniel Vetter
2017-03-29 15:04   ` ✗ Fi.CI.BAT: warning for drm/fb-helper: Deferred setup support (rev3) Patchwork
2017-03-30 10:21   ` [PATCH v4 00/11] drm/fb-helper: Deferred setup support Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170329144401.1804-12-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.