From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753099AbdC2O5O (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Mar 2017 10:57:14 -0400
Received: from smida.it ([94.23.22.176]:39225 "EHLO smtp.smida.it"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751738AbdC2Oz4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Mar 2017 10:55:56 -0400
X-Greylist: delayed 313 seconds by postgrey-1.27 at vger.kernel.org; Wed, 29 Mar 2017 10:55:56 EDT
DMARC-Filter: OpenDMARC Filter v1.3.0 smtp.smida.it 706C542D81
Authentication-Results: mail.smida.it; dmarc=fail header.from=etezian.org
Date: Wed, 29 Mar 2017 23:50:35 +0900
From: Andi Shyti <andi@etezian.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andi Shyti <andi.shyti@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Jaewon Kim <jaewon02.kim@samsung.com>,
        Seung-Woo Kim <sw0312.kim@samsung.com>, linux-kernel@vger.kernel.org,
        Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH 2/2] extcon: max77843: support USB accessories as
 external USB hosts
Message-ID: <20170329145035.fmnn3wxekw5lbh3q@jack.zhora.eu>
References: <CGME20170329115509epcas5p16e5dd395695d94a294a91da6f113e5fe@epcas5p1.samsung.com>
 <20170329115453.4268-1-andi.shyti@samsung.com>
 <20170329115453.4268-3-andi.shyti@samsung.com>
 <CAJKOXPduOUF9rLXhQmKPG0uyDwuMex5FXVtS82XBE-CoHkZ28A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJKOXPduOUF9rLXhQmKPG0uyDwuMex5FXVtS82XBE-CoHkZ28A@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,

> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_1:
> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_2:
> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_3:
> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_4:
> > +                       case MAX77843_MUIC_ADC_RESERVED_ACC_5:
> 
> In commit msg you mentioned it but in code not. It looks weird to
> handle a vague "reserved" type in a specific way. How about adding
> some meaningful names instead of "reserved"? Or at least documenting,
> that they match Gear VR. Really, imagine later one would be looking at
> the code and trying to figure out why "reserved" means something

I know it's misleading, but that's the name from the datasheet,
that's why I tried to be more specific in the commit log.

In any case RESERVED_ACC stands for "reserved for external
accessory".

The Gear VR corresponds to MAX77843_MUIC_ADC_RESERVED_ACC_4, but
I don't think it's the only one, that's why it wouldn't be right
to call it e.g. MAX77843_MUIC_ADC_GEAR_VR.

I can of course add a comment on top of the above lines to make
it clearer.

Thanks,
Andi