From: Darren Hart <dvhart@infradead.org>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: Jonathan Woithe <jwoithe@just42.net>,
Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] platform/x86: fujitsu-laptop: switch to a managed backlight input device
Date: Wed, 29 Mar 2017 12:58:04 -0700 [thread overview]
Message-ID: <20170329195804.GD15472@localhost.localdomain> (raw)
In-Reply-To: <20170320093224.18541-3-kernel@kempniu.pl>
On Mon, Mar 20, 2017 at 10:32:18AM +0100, Michał Kępień wrote:
> Use a managed input device for brightness events in order to simplify
> two error paths and one cleanup function while also reducing the number
> of local variables required. Remove double assignment to make
> checkpatch happy.
>
> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
And this one mostly addresses my commentary on 1/8.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-03-29 19:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:32 [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling Michał Kępień
2017-03-20 9:32 ` [PATCH 1/8] platform/x86: fujitsu-laptop: move backlight input device setup to a separate function Michał Kępień
2017-03-29 19:54 ` Darren Hart
2017-03-30 4:04 ` Jonathan Woithe
2017-03-20 9:32 ` [PATCH 2/8] platform/x86: fujitsu-laptop: switch to a managed backlight input device Michał Kępień
2017-03-29 19:58 ` Darren Hart [this message]
2017-03-20 9:32 ` [PATCH 3/8] platform/x86: fujitsu-laptop: use a sparse keymap for brightness key event generation Michał Kępień
2017-03-20 9:32 ` [PATCH 4/8] platform/x86: fujitsu-laptop: move hotkey input device setup to a separate function Michał Kępień
2017-03-29 20:12 ` Darren Hart
2017-03-20 9:32 ` [PATCH 5/8] platform/x86: fujitsu-laptop: switch to a managed hotkey input device Michał Kępień
2017-03-20 9:32 ` [PATCH 6/8] platform/x86: fujitsu-laptop: use a sparse keymap for hotkey event generation Michał Kępień
2017-03-31 11:22 ` Michał Kępień
2017-04-01 20:00 ` Darren Hart
2017-04-02 9:01 ` Jonathan Woithe
2017-03-20 9:32 ` [PATCH 7/8] platform/x86: fujitsu-laptop: model-dependent sparse keymap overrides Michał Kępień
2017-03-27 0:40 ` Jonathan Woithe
2017-03-20 9:32 ` [PATCH 8/8] platform/x86: fujitsu-laptop: remove keycode fields from struct fujitsu_bl Michał Kępień
2017-03-24 10:49 ` [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling Jonathan Woithe
2017-03-27 23:57 ` Jonathan Woithe
2017-03-28 6:16 ` Michał Kępień
2017-03-28 23:00 ` Jonathan Woithe
2017-03-29 7:19 ` Michał Kępień
2017-03-29 16:35 ` Andy Shevchenko
2017-03-30 3:36 ` Darren Hart
2017-03-30 3:56 ` Jonathan Woithe
2017-03-30 5:04 ` Darren Hart
2017-03-30 6:41 ` Michał Kępień
2017-03-30 22:25 ` Jonathan Woithe
2017-03-29 19:28 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329195804.GD15472@localhost.localdomain \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=jwoithe@just42.net \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.