Re: [PATCH v3 3/4] xenstore: rework of transaction handling

From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com,
	wei.liu2@citrix.com
Subject: Re: [PATCH v3 3/4] xenstore: rework of transaction handling
Date: Thu, 30 Mar 2017 12:17:00 +0100	[thread overview]
Message-ID: <20170330111700.kvssrw3nhk5bhttx@citrix.com> (raw)
In-Reply-To: <20170328162615.16857-4-jgross@suse.com>

On Tue, Mar 28, 2017 at 06:26:14PM +0200, Juergen Gross wrote:
[...]
> +
> +static char *transaction_get_node_name(void *ctx, struct transaction *trans,
> +				       const char *name)
> +{
> +	return talloc_asprintf(ctx, "%"PRIu64"/%s", trans->generation, name);
> +}
> +
> +/*
> + * Prepend the transaction to name if appropriate.
> + * In a transaction the transaction will be prepended for:
> + * - write accesses
> + * - read accesses of a node which has been written already in
> + *   the same transaction
> + */
> +int transaction_prepend(struct connection *conn, const char *name,
> +			enum node_access_type type, TDB_DATA *key)

In the code this function is only ever called with type==READ, so either
you miss one callsite for write access or the comment is wrong.

I would like to hear from you before continuing.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel