From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933362AbdC3KFx (ORCPT ); Thu, 30 Mar 2017 06:05:53 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:33869 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933329AbdC3KFg (ORCPT ); Thu, 30 Mar 2017 06:05:36 -0400 Date: Thu, 30 Mar 2017 12:05:22 +0200 From: Boris Brezillon To: Max Filippov Cc: Christoph Hellwig , Chris Zankel , "linux-xtensa@linux-xtensa.org" , Maxime Ripard , Thomas Petazzoni , LKML Subject: Re: [PATCH] xtensa: Fix mmap() support Message-ID: <20170330120522.4af7bcbc@bbrezillon> In-Reply-To: References: <1490689242-5097-1-git-send-email-boris.brezillon@free-electrons.com> <20170330103032.35558cf3@bbrezillon> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Mar 2017 02:05:28 -0700 Max Filippov wrote: > On Thu, Mar 30, 2017 at 1:30 AM, Boris Brezillon > wrote: > >> Could you please instead check if the dma_common_mmap works for you > >> with the attached patch? > > > > I will. BTW, shouldn't it be > > > > if (off >= XCHAL_KSEG_SIZE) > > > > instead of > > > > if (off > XCHAL_KSEG_SIZE) > > ? > > Oops. Yes, you're right. > It works, you can add my Tested-by: Boris Brezillon Reviewed-by: Boris Brezillon when submitting the patch. Thanks, Boris