From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org
Subject: Re: [PATCH v2 3/4] devtools: remove special case build for perf thread example
Date: Thu, 30 Mar 2017 16:30:03 +0100 [thread overview]
Message-ID: <20170330153003.GA14552@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1632639.Ait0E45soG@xps13>
On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> 2017-03-29 17:38, Bruce Richardson:
> > Since performance-thread example app is now built as part of make examples
> > we don't need a special case line for it in testbuild.sh script
> [...]
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -237,9 +237,6 @@ for conf in $configs ; do
> > EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > O=$(readlink -m $dir/examples)
> > ! echo $target | grep -q '^x86_64' || \
> > - make -j$J -sC examples/performance-thread \
> > - EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > - O=$(readlink -m $dir/examples/performance-thread)
>
> You are missing the x86_64 check.
That's in the makefile in the first patch
>
> This patch should be squashed with the first one.
>
Sure. Doesn't matter to me!
/Bruce
next prev parent reply other threads:[~2017-03-30 15:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 14:04 [PATCH 0/4] improve build coverage Bruce Richardson
2017-03-29 14:04 ` [PATCH 1/4] examples: enable performance-thread in examples build Bruce Richardson
2017-03-29 14:04 ` [PATCH 2/4] config: enable crypto scheduler PMD by default Bruce Richardson
2017-03-30 14:48 ` Zhang, Roy Fan
2017-03-29 14:04 ` [PATCH 3/4] devtools: remove special case build for perf thread example Bruce Richardson
2017-03-29 14:04 ` [PATCH 4/4] devtools: add autotest app to build script Bruce Richardson
2017-03-29 16:38 ` [PATCH v2 0/4] improve build coverage Bruce Richardson
2017-03-29 16:38 ` [PATCH v2 1/4] examples: enable performance-thread in examples build Bruce Richardson
2017-03-30 7:45 ` Declan Doherty
2017-03-29 16:38 ` [PATCH v2 2/4] config: enable crypto scheduler PMD by default Bruce Richardson
2017-03-30 7:45 ` Declan Doherty
2017-03-29 16:38 ` [PATCH v2 3/4] devtools: remove special case build for perf thread example Bruce Richardson
2017-03-30 7:46 ` Declan Doherty
2017-03-30 14:31 ` Thomas Monjalon
2017-03-30 15:30 ` Bruce Richardson [this message]
2017-03-30 20:38 ` Thomas Monjalon
2017-03-31 9:15 ` Bruce Richardson
2017-03-31 9:56 ` Thomas Monjalon
2017-03-29 16:38 ` [PATCH v2 4/4] devtools: add autotest app to build script Bruce Richardson
2017-03-30 7:47 ` Declan Doherty
2017-03-30 14:36 ` Thomas Monjalon
2017-03-30 15:33 ` Bruce Richardson
2017-03-30 20:42 ` Thomas Monjalon
2017-04-04 13:03 ` Ferruh Yigit
2017-04-06 19:45 ` [PATCH v2 0/4] improve build coverage Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330153003.GA14552@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.