From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934715AbdC3XYp (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Mar 2017 19:24:45 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:43036 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932323AbdC3XYS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Mar 2017 19:24:18 -0400
Date: Thu, 30 Mar 2017 16:24:16 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH] kernel/reboot: add devm_register_reboot_notifier
Message-Id: <20170330162416.cd517a26b872358737b20909@linux-foundation.org>
In-Reply-To: <CAHQ1cqEUTo3J2zzbiwZ7COHJs6oLbs_Mh88JU8zk7jEjFzyHEg@mail.gmail.com>
References: <20170320171753.1705-1-andrew.smirnov@gmail.com>
        <20170329161738.ce8c1508f648f9174f0cf8bb@linux-foundation.org>
        <CAHQ1cqEUTo3J2zzbiwZ7COHJs6oLbs_Mh88JU8zk7jEjFzyHEg@mail.gmail.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 30 Mar 2017 15:55:43 -0700 Andrey Smirnov <andrew.smirnov@gmail.com> wrote:

> On Wed, Mar 29, 2017 at 4:17 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Mon, 20 Mar 2017 10:17:53 -0700 Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
> >
> >> Add devm_* wrapper around register_reboot_notifier to simplify device
> >> specific reboot notifier registration/unregistration.
> >>
> >> --- a/kernel/reboot.c
> >> +++ b/kernel/reboot.c
> >> @@ -104,6 +104,33 @@ int unregister_reboot_notifier(struct notifier_block *nb)
> >>  }
> >>  EXPORT_SYMBOL(unregister_reboot_notifier);
> >>
> >> +static void devm_unregister_reboot_notifier(struct device *dev, void *res)
> >> +{
> >> +     WARN_ON(unregister_reboot_notifier(*(struct notifier_block **)res));
> >> +}
> >> +
> >> +int devm_register_reboot_notifier(struct device *dev, struct notifier_block *nb)
> >> +{
> >> +     struct notifier_block **rcnb;
> >> +     int ret;
> >> +
> >> +     rcnb = devres_alloc(devm_unregister_reboot_notifier,
> >> +                         sizeof(*rcnb), GFP_KERNEL);
> >> +     if (!rcnb)
> >> +             return -ENOMEM;
> >> +
> >> +     ret = register_reboot_notifier(nb);
> >> +     if (!ret) {
> >> +             *rcnb = nb;
> >> +             devres_add(dev, rcnb);
> >> +     } else {
> >> +             devres_free(rcnb);
> >> +     }
> >> +
> >> +     return ret;
> >> +}
> >> +EXPORT_SYMBOL(devm_register_reboot_notifier);
> >
> > Seems reasonable.  Can we please have some patches which actually use
> > this?
> 
> I will be submitting a serdev/watchdog driver in next couple of weeks,
> I can CC you on that thread.

It would be nice to convert some other call sites as well, please - at
least to get additional test coverage and to demonstrate the usefulness
of the new interface.