From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933973AbdC3Qdr (ORCPT ); Thu, 30 Mar 2017 12:33:47 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:46332 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933687AbdC3Qdp (ORCPT ); Thu, 30 Mar 2017 12:33:45 -0400 From: Christoph Hellwig To: Linus Torvalds , Alexander Viro Cc: linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, libc-alpha@sourceware.org Subject: [PATCH 2/2] fs: reject unknown open flags Date: Thu, 30 Mar 2017 18:33:27 +0200 Message-Id: <20170330163327.23920-3-hch@lst.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170330163327.23920-1-hch@lst.de> References: <20170330163327.23920-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This way userspace can probe for actually supported flags. Signed-off-by: Christoph Hellwig --- fs/open.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/open.c b/fs/open.c index 949cef29c3bb..9106ed7310f0 100644 --- a/fs/open.c +++ b/fs/open.c @@ -900,6 +900,9 @@ static inline int build_open_flags(int flags, umode_t mode, struct open_flags *o int lookup_flags = 0; int acc_mode = ACC_MODE(flags); + if (flags & ~VALID_OPEN_FLAGS) + return -EINVAL; + if (flags & (O_CREAT | __O_TMPFILE)) op->mode = (mode & S_IALLUGO) | S_IFREG; else -- 2.11.0