From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allain Legacy Subject: [PATCH v4 5/6] cfgfile: increase local buffer size for max name and value Date: Thu, 30 Mar 2017 14:54:06 -0400 Message-ID: <20170330185407.61220-6-allain.legacy@windriver.com> References: <20170328164431.12475-1-allain.legacy@windriver.com> <20170330185407.61220-1-allain.legacy@windriver.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , To: , Return-path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by dpdk.org (Postfix) with ESMTP id D92062C66 for ; Thu, 30 Mar 2017 20:54:40 +0200 (CEST) In-Reply-To: <20170330185407.61220-1-allain.legacy@windriver.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Joseph Richard When parsing a ini file with a "key = value" line that has both "key" and "value" sized to the maximum allowed length causes a parsing failure. The internal "buffer" variable should be sized at least as large as the maximum for both fields. This commit updates the local array to be sized to hold the max name, max value, " = ", and the nul terminator. Signed-off-by: Allain Legacy Acked-by: Keith Wiles --- lib/librte_cfgfile/rte_cfgfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c index e4a3885b7..4ef7decb3 100644 --- a/lib/librte_cfgfile/rte_cfgfile.c +++ b/lib/librte_cfgfile/rte_cfgfile.c @@ -148,7 +148,7 @@ rte_cfgfile_load_with_params(const char *filename, int flags, int allocated_entries = 0; int curr_section = -1; int curr_entry = -1; - char buffer[256] = {0}; + char buffer[CFG_NAME_LEN + CFG_VALUE_LEN + 4] = {0}; int lineno = 0; struct rte_cfgfile *cfg = NULL; -- 2.12.1