From: Bjorn Helgaas <helgaas@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Yongji Xie <xyjxie@linux.vnet.ibm.com>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, alex.williamson@redhat.com,
gwshan@linux.vnet.ibm.com, aik@ozlabs.ru, paulus@samba.org,
zhong@linux.vnet.ibm.com
Subject: Re: [PATCH v9 2/3] PCI: Add a macro to set default alignment for all PCI devices
Date: Thu, 30 Mar 2017 18:13:26 -0500 [thread overview]
Message-ID: <20170330231326.GB2496@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1490610350.3177.71.camel@kernel.crashing.org>
On Mon, Mar 27, 2017 at 09:25:50PM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2017-03-27 at 21:17 +1100, Michael Ellerman wrote:
> > > If so, is it acceptable to force that kernel to user 64K alignment
> > > even
> > > when it's running on non-PowerNV systems?
> >
> > Probably, but I'm not sure TBH. Benh will know, I'll try and get his
> > attention.
>
> Can we make the alignment PAGE_SIZE ? I think that should be ok as long
> as it doesn't try to re-allocate BARs for devices that have already
> been properly allocated by firmware (ie, PowerMac, if you mess around
> with the MacIO chip on these, bad things will happen).
I think this *will* change BARs even if they've already been allocated
by firmware, because it affects this path that is used for every
device:
pci_device_add
pci_reassigndev_resource_alignment
pci_specified_resource_alignment
align = PCIBIOS_DEFAULT_ALIGNMENT
I'm looking for an update that fixes the minor comment issues and
possibly addresses this PowerMac question.
Bjorn
next prev parent reply other threads:[~2017-03-30 23:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 6:45 [PATCH v9 0/3] PCI: Introduce a way to enforce all MMIO BARs not to share PAGE_SIZE Yongji Xie
2017-02-15 6:45 ` [PATCH v9 1/3] PCI: A fix for caculating bridge window's size and alignment Yongji Xie
2017-02-15 6:45 ` [PATCH v9 2/3] PCI: Add a macro to set default alignment for all PCI devices Yongji Xie
2017-03-23 20:53 ` Bjorn Helgaas
2017-03-23 21:57 ` Bjorn Helgaas
2017-03-25 12:36 ` Yongji Xie
2017-03-27 10:17 ` Michael Ellerman
2017-03-27 10:25 ` Benjamin Herrenschmidt
2017-03-30 23:13 ` Bjorn Helgaas [this message]
2017-02-15 6:45 ` [PATCH v9 3/3] PCI: Don't extend device's size when using default alignment for all devices Yongji Xie
2017-03-23 21:55 ` Bjorn Helgaas
2017-03-25 12:46 ` Yongji Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330231326.GB2496@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=xyjxie@linux.vnet.ibm.com \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.