All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	tipbuild@zytor.com, Ingo Molnar <mingo@kernel.org>
Subject: Re: [tip:x86/asm 3/3] lib/bug.c:135: undefined reference to `__start___bug_table'
Date: Fri, 31 Mar 2017 08:27:27 +0800	[thread overview]
Message-ID: <20170331002727.vtpxqhnruh57t75d@wfg-t540p.sh.intel.com> (raw)
In-Reply-To: <20170330155327.5hea4ajxnbdrephe@hirez.programming.kicks-ass.net>

On Thu, Mar 30, 2017 at 05:53:27PM +0200, Peter Zijlstra wrote:
>On Thu, Mar 30, 2017 at 05:49:27PM +0200, Peter Zijlstra wrote:
>> On Thu, Mar 30, 2017 at 09:02:31PM +0800, kbuild test robot wrote:
>> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/asm
>> > head:   19d436268dde95389c616bb3819da73f0a8b28a8
>> > commit: 19d436268dde95389c616bb3819da73f0a8b28a8 [3/3] debug: Add _ONCE() logic to report_bug()
>> > config: arm-efm32_defconfig (attached as .config)
>> > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
>> > reproduce:
>> >         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> >         chmod +x ~/bin/make.cross
>> >         git checkout 19d436268dde95389c616bb3819da73f0a8b28a8
>> >         # save the attached .config to linux build tree
>> >         make.cross ARCH=arm
>> >
>> > All errors (new ones prefixed by >>):
>> >
>> >    lib/lib.a(bug.o): In function `find_bug':
>> > >> lib/bug.c:135: undefined reference to `__start___bug_table'
>> > >> lib/bug.c:135: undefined reference to `__stop___bug_table'
>>
>> Blergh.. this cures it for me.
>>
>> Ideally all those would use RW_DATA_SECTION, but alas.
>>
>
>> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
>> index c74ae9c..c8a3b61 100644
>> --- a/arch/x86/kernel/vmlinux.lds.S
>> +++ b/arch/x86/kernel/vmlinux.lds.S
>> @@ -146,6 +146,7 @@ SECTIONS
>>  		_edata = .;
>>  	} :data
>>
>> +	BUG_TABLE
>>
>>  	. = ALIGN(PAGE_SIZE);
>>  	__vvar_page = .;
>
>Also, I have absolutely 0 clues as to why x86 builds without this :/

Yes there are no x86 build failures with this error message.
It only occurs in arm and c6x.

Regards,
Fengguang

  reply	other threads:[~2017-03-31  0:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 13:02 [tip:x86/asm 3/3] lib/bug.c:135: undefined reference to `__start___bug_table' kbuild test robot
2017-03-30 15:49 ` Peter Zijlstra
2017-03-30 15:53   ` Peter Zijlstra
2017-03-31  0:27     ` Fengguang Wu [this message]
2017-04-03  8:27   ` [tip:x86/asm] debug: Fix __bug_table[] in arch linker scripts tip-bot for Peter Zijlstra
2017-04-03  9:57     ` hpa
2017-04-03 12:25       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331002727.vtpxqhnruh57t75d@wfg-t540p.sh.intel.com \
    --to=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tipbuild@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.