From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC04721A0482F for ; Fri, 31 Mar 2017 00:10:09 -0700 (PDT) Date: Fri, 31 Mar 2017 00:09:50 -0700 From: Christoph Hellwig Subject: Re: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory. Message-ID: <20170331070950.GA9059@infradead.org> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-6-git-send-email-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1490911959-5146-6-git-send-email-logang@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: Jens Axboe , Jason Gunthorpe , "James E.J. Bottomley" , "Martin K. Petersen" , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, Steve Wise , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Keith Busch , linux-scsi@vger.kernel.org, Max Gurtovoy , Christoph Hellwig List-ID: You're calling memcpy_{to,from}_iomem on non-__iomem pointers. This is a fundamental no-go as we keep I/O memory separate from kernel pointers. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory. Date: Fri, 31 Mar 2017 00:09:50 -0700 Message-ID: <20170331070950.GA9059@infradead.org> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-6-git-send-email-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1490911959-5146-6-git-send-email-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: Jens Axboe , Jason Gunthorpe , "James E.J. Bottomley" , "Martin K. Petersen" , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Steve Wise , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Keith Busch , linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Max Gurtovoy , Christoph Hellwig List-Id: linux-rdma@vger.kernel.org You're calling memcpy_{to,from}_iomem on non-__iomem pointers. This is a fundamental no-go as we keep I/O memory separate from kernel pointers. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754450AbdCaHKL (ORCPT ); Fri, 31 Mar 2017 03:10:11 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:51200 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753302AbdCaHKK (ORCPT ); Fri, 31 Mar 2017 03:10:10 -0400 Date: Fri, 31 Mar 2017 00:09:50 -0700 From: Christoph Hellwig To: Logan Gunthorpe Cc: Christoph Hellwig , Sagi Grimberg , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe , linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory. Message-ID: <20170331070950.GA9059@infradead.org> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-6-git-send-email-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490911959-5146-6-git-send-email-logang@deltatee.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org You're calling memcpy_{to,from}_iomem on non-__iomem pointers. This is a fundamental no-go as we keep I/O memory separate from kernel pointers. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 31 Mar 2017 00:09:50 -0700 From: Christoph Hellwig To: Logan Gunthorpe Cc: Christoph Hellwig , Sagi Grimberg , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe , linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory. Message-ID: <20170331070950.GA9059@infradead.org> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-6-git-send-email-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1490911959-5146-6-git-send-email-logang@deltatee.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: You're calling memcpy_{to,from}_iomem on non-__iomem pointers. This is a fundamental no-go as we keep I/O memory separate from kernel pointers. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Fri, 31 Mar 2017 00:09:50 -0700 Subject: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory. In-Reply-To: <1490911959-5146-6-git-send-email-logang@deltatee.com> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-6-git-send-email-logang@deltatee.com> Message-ID: <20170331070950.GA9059@infradead.org> You're calling memcpy_{to,from}_iomem on non-__iomem pointers. This is a fundamental no-go as we keep I/O memory separate from kernel pointers.