From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932841AbdCaH64 (ORCPT ); Fri, 31 Mar 2017 03:58:56 -0400 Received: from www.zeus03.de ([194.117.254.33]:46600 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752999AbdCaH6y (ORCPT ); Fri, 31 Mar 2017 03:58:54 -0400 Date: Fri, 31 Mar 2017 09:58:51 +0200 From: Wolfram Sang To: "Tobin C. Harding" Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , devel@linuxdriverproject.org, Tycho Andersen Subject: Re: [PATCH RFC] remove custom Michael MIC implementation Message-ID: <20170331075851.GB1435@katana> References: <1490935659-7196-1-git-send-email-me@tobin.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kORqDWCi7qDJ0mEj" Content-Disposition: inline In-Reply-To: <1490935659-7196-1-git-send-email-me@tobin.cc> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kORqDWCi7qDJ0mEj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > The code is untested, I have hardware in the mail. Cool! > If any one is interested and has any comments I would really like to > hear them. I am open to all suggestions (even down to trivial coding > style issues). I'll just repeat that the key move to get this driver out of staging is to get away from the WEXT interface to CFG80211. Otherwise no chance that wireless maintainers will even look at it. This is a huge change but once it is done, features like Michael MIC come with it for free (from what I recall, I am not a wireless expert myself). Without the CFG80211 conversion, replacing the Michael custom implementation with the in-kernel one makes the driver a tad better and is good exercise. However, it will sadly not help to get the driver out of staging. But if you want a clean WEXT driver first, this is a step in the right direction. --kORqDWCi7qDJ0mEj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJY3gw7AAoJEBQN5MwUoCm2ti4P/3bU3Jzl76PuwGaiGA3YcFrs 7rNBkfCNFTZdzSmy4P9lXW3tHfgT7b8c0/oRvxVFDEK7YtFflH40sxwpAv/OTayg 5JxWoYU3eQPHwx2NsgNhKdpoEiKhUfRg6cgaU1CwLaRy6thw4aIM8L9zKu+aZB72 CaWFp/6LDMy1/r3i5IoNsR0dg5sJcFOHZFeF3lTuJhkRQF5fvjIa0myA6VTLOhhz 5M10WtIy+nRGk2IrxosWFcA4MioD4QFbm9Lgzec69g23II8NPFpxKN/jrsdrFt/y uONTJWj0fv2dGM2ZRaLQnVDISw4hEpl49rAyXUaoLPQnKo9xSCSJoGR/gfsZIvaJ Ucex4FCFIqM5rCyQNVxOsVn8VCYykOPYOeh2AxHSB5QTQ9k3YWxUZwWxGAc4Ah5w hVHDX+bzzcn5aK0aNX5SVKhZ+vL8IkCdU5NnlZM1IDj/8abc04P1lep8BORyDvWU bdfulZvjfykKzuVdosEmFf2dhf7m43TywdvJ9w3Y524mGjAowRT8mR1tPrn1LlTO KPn0FSvsm6msDQpnDVSZqvNvccEhrnIXdqXirIbf1NPgnJEiXxHsWrCdso766p2r ynIp+UcMkVo/7kZkX/S7Remo28O5w7uW8qluXO942jQLPGnkLTfMMGpuYW9eOs3l EZDfpghpQtvwDZaThtrE =oiPw -----END PGP SIGNATURE----- --kORqDWCi7qDJ0mEj--