From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu.Dudau@arm.com (Liviu Dudau) Date: Fri, 31 Mar 2017 11:21:35 +0100 Subject: [PATCH 3/3] drm/arm: hdlcd: check for rotation In-Reply-To: <20170331101123.GK30290@intel.com> References: <20170331094937.GO7909@n2100.armlinux.org.uk> <20170331101123.GK30290@intel.com> Message-ID: <20170331102135.GE13355@e110455-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 31, 2017 at 01:11:23PM +0300, Ville Syrj?l? wrote: > On Fri, Mar 31, 2017 at 10:51:52AM +0100, Russell King wrote: > > hdlcd does not support rotation - check for it and reject plane updates > > that try to rotate a plane. > > > > Signed-off-by: Russell King > > --- > > drivers/gpu/drm/arm/hdlcd_crtc.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c > > index cf70184fd028..171acc842368 100644 > > --- a/drivers/gpu/drm/arm/hdlcd_crtc.c > > +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c > > @@ -215,6 +215,10 @@ static int hdlcd_plane_atomic_check(struct drm_plane *plane, > > if (!crtc) > > return 0; > > > > + /* We do not support rotation */ > > + if (state->rotation != DRM_ROTATE_0) > > + return -EINVAL; > > This can't happen unless you attach a rotation property with a bogus > set of supported rotations to the plane. Which we don't. I did toy with the idea of adding it as one can hack support for 0? and 180? rotation by playing with the line pitch, I've even created a patch but in the end I've decided not to publish it. If there is anyone interested at some moment on this, I can dig it out. Best regards, Liviu > > > + > > crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc); > > if (!crtc_state->enable) > > return -EINVAL; > > -- > > 2.7.4 > > -- > Ville Syrj?l? > Intel OTC -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ?\_(?)_/? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: Re: [PATCH 3/3] drm/arm: hdlcd: check for rotation Date: Fri, 31 Mar 2017 11:21:35 +0100 Message-ID: <20170331102135.GE13355@e110455-lin.cambridge.arm.com> References: <20170331094937.GO7909@n2100.armlinux.org.uk> <20170331101123.GK30290@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E2D46E083 for ; Fri, 31 Mar 2017 10:21:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170331101123.GK30290@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: DRI devel , Russell King , Mali DP Maintainers , LAKML List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXIgMzEsIDIwMTcgYXQgMDE6MTE6MjNQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgTWFyIDMxLCAyMDE3IGF0IDEwOjUxOjUyQU0gKzAxMDAsIFJ1c3Nl bGwgS2luZyB3cm90ZToKPiA+IGhkbGNkIGRvZXMgbm90IHN1cHBvcnQgcm90YXRpb24gLSBjaGVj ayBmb3IgaXQgYW5kIHJlamVjdCBwbGFuZSB1cGRhdGVzCj4gPiB0aGF0IHRyeSB0byByb3RhdGUg YSBwbGFuZS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogUnVzc2VsbCBLaW5nIDxybWsra2VybmVs QGFybWxpbnV4Lm9yZy51az4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vaGRsY2Rf Y3J0Yy5jIHwgNCArKysrCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9oZGxjZF9jcnRjLmMgYi9kcml2 ZXJzL2dwdS9kcm0vYXJtL2hkbGNkX2NydGMuYwo+ID4gaW5kZXggY2Y3MDE4NGZkMDI4Li4xNzFh Y2M4NDIzNjggMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXJtL2hkbGNkX2NydGMu Ywo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FybS9oZGxjZF9jcnRjLmMKPiA+IEBAIC0yMTUs NiArMjE1LDEwIEBAIHN0YXRpYyBpbnQgaGRsY2RfcGxhbmVfYXRvbWljX2NoZWNrKHN0cnVjdCBk cm1fcGxhbmUgKnBsYW5lLAo+ID4gIAlpZiAoIWNydGMpCj4gPiAgCQlyZXR1cm4gMDsKPiA+ICAK PiA+ICsJLyogV2UgZG8gbm90IHN1cHBvcnQgcm90YXRpb24gKi8KPiA+ICsJaWYgKHN0YXRlLT5y b3RhdGlvbiAhPSBEUk1fUk9UQVRFXzApCj4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiAKPiBUaGlz IGNhbid0IGhhcHBlbiB1bmxlc3MgeW91IGF0dGFjaCBhIHJvdGF0aW9uIHByb3BlcnR5IHdpdGgg YSBib2d1cwo+IHNldCBvZiBzdXBwb3J0ZWQgcm90YXRpb25zIHRvIHRoZSBwbGFuZS4KCldoaWNo IHdlIGRvbid0LiBJIGRpZCB0b3kgd2l0aCB0aGUgaWRlYSBvZiBhZGRpbmcgaXQgYXMgb25lIGNh biBoYWNrIHN1cHBvcnQgZm9yIDDCsCBhbmQgMTgwwrAKcm90YXRpb24gYnkgcGxheWluZyB3aXRo IHRoZSBsaW5lIHBpdGNoLCBJJ3ZlIGV2ZW4gY3JlYXRlZCBhIHBhdGNoIGJ1dCBpbiB0aGUgZW5k IEkndmUKZGVjaWRlZCBub3QgdG8gcHVibGlzaCBpdC4gSWYgdGhlcmUgaXMgYW55b25lIGludGVy ZXN0ZWQgYXQgc29tZSBtb21lbnQgb24gdGhpcywgSSBjYW4gZGlnIGl0IG91dC4KCkJlc3QgcmVn YXJkcywKTGl2aXUKCj4gCj4gPiArCj4gPiAgCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9l eGlzdGluZ19jcnRjX3N0YXRlKHN0YXRlLT5zdGF0ZSwgY3J0Yyk7Cj4gPiAgCWlmICghY3J0Y19z dGF0ZS0+ZW5hYmxlKQo+ID4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gPiAtLSAKPiA+IDIuNy40Cj4g Cj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwgT1RDCgotLSAKPT09PT09PT09PT09PT09 PT09PT0KfCBJIHdvdWxkIGxpa2UgdG8gfAp8IGZpeCB0aGUgd29ybGQsICB8CnwgYnV0IHRoZXkn cmUgbm90IHwKfCBnaXZpbmcgbWUgdGhlICAgfAogXCBzb3VyY2UgY29kZSEgIC8KICAtLS0tLS0t LS0tLS0tLS0KICAgIMKvXF8o44OEKV8vwq8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==