From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, lei.cao@stratus.com
Subject: Re: [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public
Date: Fri, 31 Mar 2017 15:39:23 +0200 [thread overview]
Message-ID: <20170331133923.GB6019@potion> (raw)
In-Reply-To: <1490961203-7139-3-git-send-email-pbonzini@redhat.com>
2017-03-31 13:53+0200, Paolo Bonzini:
> Its value has never changed; we might as well make it part of the ABI instead
> of using the return value of KVM_CHECK_EXTENSION(KVM_CAP_COALESCED_MMIO).
>
> Because PPC does not always make MMIO available, the code has to be made
> dependent on CONFIG_KVM_MMIO rather than KVM_COALESCED_MMIO_PAGE_OFFSET.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
I like the change to CONFIG_KVM_MMIO and the interface isn't suited for
dynamic offsets based on enabled features anyway ...
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
prev parent reply other threads:[~2017-03-31 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 11:53 [PATCH 0/3] kvm: API adjustments for dirty page ring patches Paolo Bonzini
2017-03-31 11:53 ` [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture agnostic Paolo Bonzini
2017-03-31 13:21 ` Radim Krčmář
2017-03-31 13:41 ` Radim Krčmář
2017-04-03 11:29 ` David Hildenbrand
2017-03-31 11:53 ` [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public Paolo Bonzini
2017-03-31 13:39 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331133923.GB6019@potion \
--to=rkrcmar@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lei.cao@stratus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.