From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933247AbdCaOqB (ORCPT ); Fri, 31 Mar 2017 10:46:01 -0400 Received: from merlin.infradead.org ([205.233.59.134]:48634 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933108AbdCaOp7 (ORCPT ); Fri, 31 Mar 2017 10:45:59 -0400 Date: Fri, 31 Mar 2017 16:45:46 +0200 From: Peter Zijlstra To: Andi Kleen Cc: Stephen Rothwell , Andrew Morton , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux-Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: manual merge of the akpm tree with the tip tree Message-ID: <20170331144546.4bi6lnrcx4t6cyze@hirez.programming.kicks-ass.net> References: <20170331164451.519d1d7e@canb.auug.org.au> <20170331064228.2u6x3s4yp6xolsbw@hirez.programming.kicks-ass.net> <20170331135448.GE4543@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170331135448.GE4543@tassilo.jf.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 31, 2017 at 06:54:48AM -0700, Andi Kleen wrote: > > Argh! > > > > Andrew, please drop that patch. And the x86 out-of-line of __atomic_add_unless(). > > Why dropping the second? Do you have something better? The try_cmpxchg() patches save about half the text, and do not have the out-of-line penalty as shown here: https://lkml.kernel.org/r/20170322165144.dtidvvbxey7w5pbd@hirez.programming.kicks-ass.net > On the first there were no 0day regressions, so at least basic performance > checking has been done. The first is superseded by much better patches in the scheduler tree.