From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933411AbdCaSV2 (ORCPT ); Fri, 31 Mar 2017 14:21:28 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:42129 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933302AbdCaSV0 (ORCPT ); Fri, 31 Mar 2017 14:21:26 -0400 Date: Fri, 31 Mar 2017 20:21:11 +0200 From: Andrew Lunn To: Ralph Sennhauser Cc: linux-arm-kernel@lists.infradead.org, Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes Message-ID: <20170331182111.GJ22609@lunn.ch> References: <20170331074115.8111-1-ralph.sennhauser@gmail.com> <20170331165015.GJ12814@lunn.ch> <20170331193920.030d9ca8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170331193920.030d9ca8@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 31, 2017 at 07:39:20PM +0200, Ralph Sennhauser wrote: > On Fri, 31 Mar 2017 18:50:15 +0200 > Andrew Lunn wrote: > > > > - sata@a8000 { > > > + satac0: sata@a8000 { > > > > Hi Ralph > > > > Why the c in satac0? > > For controller and to not conflict with a use case of sata0 for a port, > similarly to pciec and pcie1. See armada-385-synology-ds116.dts. :~/linux/arch/arm/boot/dts$ ls *ds116* ls: cannot access '*ds116*': No such file or directory But anyway, a few boards seem to solve this by calling the controller node ahci0: and the port sata0: > > > - usb3@f0000 { > > > + usb3_0: usb3@f0000 { > > > compatible = > > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 0x4000>; > > > interrupts = > > IRQ_TYPE_LEVEL_HIGH>; @@ -598,7 +598,7 @@ > > > status = "disabled"; > > > }; > > > > > > - usb3@f8000 { > > > + usb3_1: usb3@f8000 { > > > compatible = > > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 0x4000>; > > > interrupts = > > IRQ_TYPE_LEVEL_HIGH>; > > > > I can understand what you are saying. But does anybody else care? Are > > there other .dtsi files differentiating between USB 1.1, 2 and 3? > > It's handled differently where ever I looked, some do some don't. A > case for distinguishing USB 2.0 and USB 3.0 like this is > armada-388-gp.dts. Humm... /* CON4 */ usb@58000 { vcc-supply = <®_usb2_0_vbus>; status = "okay"; }; /* CON5 */ usb3@f0000 { usb-phy = <&usb2_1_phy>; status = "okay"; }; /* CON7 */ usb3@f8000 { usb-phy = <&usb3_phy>; status = "okay"; }; Is this clear? Is CON5 a USB 3 host, but has a USB 2 PHY connected to it? CON7 is the only true USB 3 port? I think some comments written in schwiizerdütsch would be clearre.:-) Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes Date: Fri, 31 Mar 2017 20:21:11 +0200 Message-ID: <20170331182111.GJ22609@lunn.ch> References: <20170331074115.8111-1-ralph.sennhauser@gmail.com> <20170331165015.GJ12814@lunn.ch> <20170331193920.030d9ca8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170331193920.030d9ca8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ralph Sennhauser Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Mar 31, 2017 at 07:39:20PM +0200, Ralph Sennhauser wrote: > On Fri, 31 Mar 2017 18:50:15 +0200 > Andrew Lunn wrote: > > > > - sata@a8000 { > > > + satac0: sata@a8000 { > > > > Hi Ralph > > > > Why the c in satac0? > > For controller and to not conflict with a use case of sata0 for a port, > similarly to pciec and pcie1. See armada-385-synology-ds116.dts. :~/linux/arch/arm/boot/dts$ ls *ds116* ls: cannot access '*ds116*': No such file or directory But anyway, a few boards seem to solve this by calling the controller node ahci0: and the port sata0: > > > - usb3@f0000 { > > > + usb3_0: usb3@f0000 { > > > compatible = > > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 0x4000>; > > > interrupts = > > IRQ_TYPE_LEVEL_HIGH>; @@ -598,7 +598,7 @@ > > > status = "disabled"; > > > }; > > > > > > - usb3@f8000 { > > > + usb3_1: usb3@f8000 { > > > compatible = > > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 0x4000>; > > > interrupts = > > IRQ_TYPE_LEVEL_HIGH>; > > > > I can understand what you are saying. But does anybody else care? Are > > there other .dtsi files differentiating between USB 1.1, 2 and 3? > > It's handled differently where ever I looked, some do some don't. A > case for distinguishing USB 2.0 and USB 3.0 like this is > armada-388-gp.dts. Humm... /* CON4 */ usb@58000 { vcc-supply = <®_usb2_0_vbus>; status = "okay"; }; /* CON5 */ usb3@f0000 { usb-phy = <&usb2_1_phy>; status = "okay"; }; /* CON7 */ usb3@f8000 { usb-phy = <&usb3_phy>; status = "okay"; }; Is this clear? Is CON5 a USB 3 host, but has a USB 2 PHY connected to it? CON7 is the only true USB 3 port? I think some comments written in schwiizerdütsch would be clearre.:-) Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Fri, 31 Mar 2017 20:21:11 +0200 Subject: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes In-Reply-To: <20170331193920.030d9ca8@gmail.com> References: <20170331074115.8111-1-ralph.sennhauser@gmail.com> <20170331165015.GJ12814@lunn.ch> <20170331193920.030d9ca8@gmail.com> Message-ID: <20170331182111.GJ22609@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 31, 2017 at 07:39:20PM +0200, Ralph Sennhauser wrote: > On Fri, 31 Mar 2017 18:50:15 +0200 > Andrew Lunn wrote: > > > > - sata at a8000 { > > > + satac0: sata at a8000 { > > > > Hi Ralph > > > > Why the c in satac0? > > For controller and to not conflict with a use case of sata0 for a port, > similarly to pciec and pcie1. See armada-385-synology-ds116.dts. :~/linux/arch/arm/boot/dts$ ls *ds116* ls: cannot access '*ds116*': No such file or directory But anyway, a few boards seem to solve this by calling the controller node ahci0: and the port sata0: > > > - usb3 at f0000 { > > > + usb3_0: usb3 at f0000 { > > > compatible = > > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 0x4000>; > > > interrupts = > > IRQ_TYPE_LEVEL_HIGH>; @@ -598,7 +598,7 @@ > > > status = "disabled"; > > > }; > > > > > > - usb3 at f8000 { > > > + usb3_1: usb3 at f8000 { > > > compatible = > > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 0x4000>; > > > interrupts = > > IRQ_TYPE_LEVEL_HIGH>; > > > > I can understand what you are saying. But does anybody else care? Are > > there other .dtsi files differentiating between USB 1.1, 2 and 3? > > It's handled differently where ever I looked, some do some don't. A > case for distinguishing USB 2.0 and USB 3.0 like this is > armada-388-gp.dts. Humm... /* CON4 */ usb at 58000 { vcc-supply = <®_usb2_0_vbus>; status = "okay"; }; /* CON5 */ usb3 at f0000 { usb-phy = <&usb2_1_phy>; status = "okay"; }; /* CON7 */ usb3 at f8000 { usb-phy = <&usb3_phy>; status = "okay"; }; Is this clear? Is CON5 a USB 3 host, but has a USB 2 PHY connected to it? CON7 is the only true USB 3 port? I think some comments written in schwiizerd??tsch would be clearre.:-) Andrew