From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933366AbdCaRj0 (ORCPT ); Fri, 31 Mar 2017 13:39:26 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36077 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933276AbdCaRjZ (ORCPT ); Fri, 31 Mar 2017 13:39:25 -0400 Date: Fri, 31 Mar 2017 19:39:20 +0200 From: Ralph Sennhauser To: Andrew Lunn Cc: linux-arm-kernel@lists.infradead.org, Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes Message-ID: <20170331193920.030d9ca8@gmail.com> In-Reply-To: <20170331165015.GJ12814@lunn.ch> References: <20170331074115.8111-1-ralph.sennhauser@gmail.com> <20170331165015.GJ12814@lunn.ch> Organization: none X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Mar 2017 18:50:15 +0200 Andrew Lunn wrote: > > - sata@a8000 { > > + satac0: sata@a8000 { > > Hi Ralph > > Why the c in satac0? For controller and to not conflict with a use case of sata0 for a port, similarly to pciec and pcie1. See armada-385-synology-ds116.dts. > > > > > - usb3@f0000 { > > + usb3_0: usb3@f0000 { > > compatible = > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 0x4000>; > > interrupts = > IRQ_TYPE_LEVEL_HIGH>; @@ -598,7 +598,7 @@ > > status = "disabled"; > > }; > > > > - usb3@f8000 { > > + usb3_1: usb3@f8000 { > > compatible = > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 0x4000>; > > interrupts = > IRQ_TYPE_LEVEL_HIGH>; > > I can understand what you are saying. But does anybody else care? Are > there other .dtsi files differentiating between USB 1.1, 2 and 3? It's handled differently where ever I looked, some do some don't. A case for distinguishing USB 2.0 and USB 3.0 like this is armada-388-gp.dts. Personally I'm only interested in there being a label, making it "natural" is a bonus though. Thanks Ralph > > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralph Sennhauser Subject: Re: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes Date: Fri, 31 Mar 2017 19:39:20 +0200 Message-ID: <20170331193920.030d9ca8@gmail.com> References: <20170331074115.8111-1-ralph.sennhauser@gmail.com> <20170331165015.GJ12814@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170331165015.GJ12814-g2DYL2Zd6BY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Lunn Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 31 Mar 2017 18:50:15 +0200 Andrew Lunn wrote: > > - sata@a8000 { > > + satac0: sata@a8000 { > > Hi Ralph > > Why the c in satac0? For controller and to not conflict with a use case of sata0 for a port, similarly to pciec and pcie1. See armada-385-synology-ds116.dts. > > > > > - usb3@f0000 { > > + usb3_0: usb3@f0000 { > > compatible = > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 0x4000>; > > interrupts = > IRQ_TYPE_LEVEL_HIGH>; @@ -598,7 +598,7 @@ > > status = "disabled"; > > }; > > > > - usb3@f8000 { > > + usb3_1: usb3@f8000 { > > compatible = > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 0x4000>; > > interrupts = > IRQ_TYPE_LEVEL_HIGH>; > > I can understand what you are saying. But does anybody else care? Are > there other .dtsi files differentiating between USB 1.1, 2 and 3? It's handled differently where ever I looked, some do some don't. A case for distinguishing USB 2.0 and USB 3.0 like this is armada-388-gp.dts. Personally I'm only interested in there being a label, making it "natural" is a bonus though. Thanks Ralph > > Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: ralph.sennhauser@gmail.com (Ralph Sennhauser) Date: Fri, 31 Mar 2017 19:39:20 +0200 Subject: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes In-Reply-To: <20170331165015.GJ12814@lunn.ch> References: <20170331074115.8111-1-ralph.sennhauser@gmail.com> <20170331165015.GJ12814@lunn.ch> Message-ID: <20170331193920.030d9ca8@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 31 Mar 2017 18:50:15 +0200 Andrew Lunn wrote: > > - sata at a8000 { > > + satac0: sata at a8000 { > > Hi Ralph > > Why the c in satac0? For controller and to not conflict with a use case of sata0 for a port, similarly to pciec and pcie1. See armada-385-synology-ds116.dts. > > > > > - usb3 at f0000 { > > + usb3_0: usb3 at f0000 { > > compatible = > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 0x4000>; > > interrupts = > IRQ_TYPE_LEVEL_HIGH>; @@ -598,7 +598,7 @@ > > status = "disabled"; > > }; > > > > - usb3 at f8000 { > > + usb3_1: usb3 at f8000 { > > compatible = > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 0x4000>; > > interrupts = > IRQ_TYPE_LEVEL_HIGH>; > > I can understand what you are saying. But does anybody else care? Are > there other .dtsi files differentiating between USB 1.1, 2 and 3? It's handled differently where ever I looked, some do some don't. A case for distinguishing USB 2.0 and USB 3.0 like this is armada-388-gp.dts. Personally I'm only interested in there being a label, making it "natural" is a bonus though. Thanks Ralph > > Andrew