From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933511AbdCaXvl (ORCPT ); Fri, 31 Mar 2017 19:51:41 -0400 Received: from mga14.intel.com ([192.55.52.115]:48967 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933485AbdCaXvh (ORCPT ); Fri, 31 Mar 2017 19:51:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,254,1486454400"; d="scan'208";a="83315514" Date: Sat, 1 Apr 2017 07:50:55 +0800 From: kbuild test robot To: Salil Mehta Cc: kbuild-all@01.org, davem@davemloft.net, salil.mehta@huawei.com, yisen.zhuang@huawei.com, mehta.salil.lnk@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, lipeng Subject: [PATCH] net: hns: fix boolreturn.cocci warnings Message-ID: <20170331235055.GA28462@lkp-wsm-ep1> References: <201704010733.8LNMN4m7%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170330153106.14344-9-salil.mehta@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1 in function 'hns_enable_serdes_lb' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: lipeng Signed-off-by: Fengguang Wu --- hns_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c @@ -1545,7 +1545,7 @@ static bool hns_enable_serdes_lb(struct /* wait h/w ready */ mdelay(300); - return 0; + return false; } static void hns_disable_serdes_lb(struct net_device *ndev)