From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7CY-00058V-JJ for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7CV-0006vd-Iz for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:34 -0400 From: Eduardo Habkost Date: Fri, 31 Mar 2017 21:46:16 -0300 Message-Id: <20170401004624.30886-12-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> Subject: [Qemu-devel] [RFC 11/19] allwinner-ahci: Remove user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laszlo Ersek , Alexander Graf , Marcel Apfelbaum , Thomas Huth , Peter Maydell , Markus Armbruster , John Snow , qemu-block@nongnu.org, Beniamino Galvani , qemu-arm@nongnu.org allwinner-ahci needs to be created and wired by the alwinner-a10 device, and won't work with -device. Remove the user_creatable flag from the device class. Cc: John Snow Cc: qemu-block@nongnu.org Cc: Beniamino Galvani Cc: Peter Maydell Cc: qemu-arm@nongnu.org Signed-off-by: Eduardo Habkost --- hw/ide/ahci.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 68f2ce09ee..f60826d6e0 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1815,11 +1815,6 @@ static void allwinner_ahci_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); dc->vmsd = &vmstate_allwinner_ahci; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable = true; } static const TypeInfo allwinner_ahci_info = { -- 2.11.0.259.g40922b1