From: Theodore Ts'o <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsck: fix type mismatches in quota warning message
Date: Sat, 1 Apr 2017 12:16:15 -0400 [thread overview]
Message-ID: <20170401161615.wmxq6rvprif7bgvk@thunk.org> (raw)
In-Reply-To: <20170331232159.GA12986@localhost.localdomain>
On Fri, Mar 31, 2017 at 07:21:59PM -0400, Eric Whitney wrote:
> The conversion operations in the format control strings found in the
> fprintf call used to print the quota warning message do not match the
> types of their corresponding arguments. Although this probably hasn't
> generally been a problem, it obfuscates a bigalloc quota accounting bug
> where the reported actual quota goes negative.
>
> Clean up the mismatches and some unnecessary casts. While we're at it,
> fix a spelling nit in a related comment.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2017-04-01 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 23:21 [PATCH] e2fsck: fix type mismatches in quota warning message Eric Whitney
2017-04-01 16:16 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170401161615.wmxq6rvprif7bgvk@thunk.org \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.