From: "J. Bruce Fields" <bfields@fieldses.org>
To: NeilBrown <neilb@suse.com>
Cc: Jason Yan <yanaijie@huawei.com>,
jlayton@poochiereds.net, linux-nfs@vger.kernel.org,
miaoxie@huawei.com, zhaohongjiang@huawei.com,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] nfsd: make strdup_if_nonnull static
Date: Sun, 2 Apr 2017 22:39:05 -0400 [thread overview]
Message-ID: <20170403023905.GA19658@fieldses.org> (raw)
In-Reply-To: <87lgridyn8.fsf@notabene.neil.brown.name>
On Mon, Apr 03, 2017 at 12:15:55PM +1000, NeilBrown wrote:
> On Fri, Mar 31 2017, J. Bruce Fields wrote:
>
> > On Thu, Mar 30, 2017 at 05:50:47PM +1100, NeilBrown wrote:
> >> On Wed, Mar 29 2017, J. Bruce Fields wrote:
> >>
> >> > Thanks, applying for 4.12.--b.
> >>
> >> Ugh... does strdup_if_nonnull() actually help readability at all?
> >> kstrdup() already handles NULL fine, which is what the name seems to
> >> suggest is happening.
> >> I would think kstrdup_report_error() is a name that better reflects the
> >> function.
> >>
> >> Or just discard it:
> >
> > Yes, what was I thinking? Just didn't read kstrdup(), I guess.
> > Applying as follows.
>
>
> Thanks.
> Feel free to add
> Signed-off-by: NeilBrown <neilb@suse.com>
>
> I probably should have stuck that in there in the first place, just in
> case.
For a small patch from a known contributor I figure the risk of just
assuming DCO case (c) is negligible. Anyway, added, thanks.
--b.
prev parent reply other threads:[~2017-04-03 2:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 8:57 [PATCH] nfsd: make strdup_if_nonnull static Jason Yan
2017-03-29 21:51 ` J. Bruce Fields
2017-03-30 6:50 ` NeilBrown
2017-03-31 20:09 ` J. Bruce Fields
2017-04-03 2:15 ` NeilBrown
2017-04-03 2:39 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403023905.GA19658@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=neilb@suse.com \
--cc=sfr@canb.auug.org.au \
--cc=yanaijie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.