From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: [PATCH] eal/linux: fix build with glibc 2.25 Date: Mon, 3 Apr 2017 14:05:14 +0530 Message-ID: <20170403083514.5401-1-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: thomas.monjalon@6wind.com, ferruh.yigit@intel.com, Jerin Jacob To: dev@dpdk.org Return-path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0072.outbound.protection.outlook.com [104.47.37.72]) by dpdk.org (Postfix) with ESMTP id 2959BDE0 for ; Mon, 3 Apr 2017 10:35:38 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" glibc 2.25 is warning about if applications depend on sys/types.h for makedev macro, it expects to be included from Found this error while testing with GCC 6.3.1 on archlinux. lib/librte_eal/linuxapp/eal/eal_pci_uio.c: In function ‘pci_mknod_uio_dev’: lib/librte_eal/linuxapp/eal/eal_pci_uio.c:134:13: error: In the GNU C Library, "makedev" is defined by . For historical compatibility, it is currently defined by as well, but we plan to remove this soon. To use "makedev", include directly. If you did not intend to use a system-defined macro "makedev", you should undefine it after including . [-Werror] dev = makedev(major, minor); ^~~~~~~~~~~~~~~~~ Signed-off-by: Jerin Jacob --- Not added the Fixes: tag because this issue is due to glibc change. --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c index 20a4a665e..fa10329fd 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c @@ -38,6 +38,7 @@ #include #include #include +#include #include #if defined(RTE_ARCH_X86) -- 2.12.1