From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuxRP-0005m1-73 for qemu-devel@nongnu.org; Mon, 03 Apr 2017 04:34:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cuxRM-000486-1G for qemu-devel@nongnu.org; Mon, 03 Apr 2017 04:34:23 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48682) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cuxRL-00046q-N6 for qemu-devel@nongnu.org; Mon, 03 Apr 2017 04:34:19 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v338Xnjd137403 for ; Mon, 3 Apr 2017 04:34:16 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0a-001b2d01.pphosted.com with ESMTP id 29jvy03dun-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 03 Apr 2017 04:34:16 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Apr 2017 09:34:14 +0100 Date: Mon, 3 Apr 2017 10:34:09 +0200 From: Cornelia Huck In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20170403103409.5930a8f3.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 10/43] s390x: made printf always compile in debug output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Danil Antonov Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, agraf@suse.de, rth@twiddle.net On Sat, 1 Apr 2017 16:45:53 +0300 Danil Antonov wrote: > From ea9cd8f02bd98548435f561e62f4f9b672318bcb Mon Sep 17 00:00:00 2001 > From: Danil Antonov > Date: Wed, 29 Mar 2017 12:26:05 +0300 > Subject: [PATCH 10/43] s390x: made printf always compile in debug output s/made/make/ (Not sure where the headers above came from; might be gmail.) > > Wrapped printf calls inside debug macros (DPRINTF) in `if` statement. > This will ensure that printf function will always compile even if debug > output is turned off and, in turn, will prevent bitrot of the format > strings. > > Signed-off-by: Danil Antonov > --- > target/s390x/kvm.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) Seems reasonable; although we should convert to tracepoints later. Queued for 2.10 (with the commit message slightly tweaked).