All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table
Date: Mon, 3 Apr 2017 12:15:02 +0100	[thread overview]
Message-ID: <20170403111502.lotjpd746vkhekkg@dell> (raw)
In-Reply-To: <20170401071854.23198-3-javier@osg.samsung.com>

On Sat, 01 Apr 2017, Javier Martinez Canillas wrote:

> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
> Changes in v3:
> - Add a vendor prefix to the compatible string (Rob Herring).
> 
> Changes in v2:
> - Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled.
> 
>  drivers/mfd/retu-mfd.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c
> index d4c114abeb75..937a1c21eec4 100644
> --- a/drivers/mfd/retu-mfd.c
> +++ b/drivers/mfd/retu-mfd.c
> @@ -308,9 +308,17 @@ static const struct i2c_device_id retu_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, retu_id);
>  
> +static const struct of_device_id retu_of_match[] = {
> +	{ .compatible = "nokia,retu-mfd" },
> +	{ .compatible = "nokia,tahvo-mfd" },

Please drop the "-mfd".

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, retu_of_match);
> +
>  static struct i2c_driver retu_driver = {
>  	.driver		= {
>  		.name = "retu-mfd",
> +		.of_match_table = retu_of_match,
>  	},
>  	.probe		= retu_probe,
>  	.remove		= retu_remove,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Javier Martinez Canillas
	<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table
Date: Mon, 3 Apr 2017 12:15:02 +0100	[thread overview]
Message-ID: <20170403111502.lotjpd746vkhekkg@dell> (raw)
In-Reply-To: <20170401071854.23198-3-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>

On Sat, 01 Apr 2017, Javier Martinez Canillas wrote:

> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
> 
> ---
> 
> Changes in v3:
> - Add a vendor prefix to the compatible string (Rob Herring).
> 
> Changes in v2:
> - Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled.
> 
>  drivers/mfd/retu-mfd.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c
> index d4c114abeb75..937a1c21eec4 100644
> --- a/drivers/mfd/retu-mfd.c
> +++ b/drivers/mfd/retu-mfd.c
> @@ -308,9 +308,17 @@ static const struct i2c_device_id retu_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, retu_id);
>  
> +static const struct of_device_id retu_of_match[] = {
> +	{ .compatible = "nokia,retu-mfd" },
> +	{ .compatible = "nokia,tahvo-mfd" },

Please drop the "-mfd".

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, retu_of_match);
> +
>  static struct i2c_driver retu_driver = {
>  	.driver		= {
>  		.name = "retu-mfd",
> +		.of_match_table = retu_of_match,
>  	},
>  	.probe		= retu_probe,
>  	.remove		= retu_remove,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-04-03 11:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  7:18 [PATCH v3 0/7] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-04-01  7:18 ` Javier Martinez Canillas
2017-04-01  7:18 ` Javier Martinez Canillas
2017-04-01  7:18 ` [PATCH v3 1/7] mfd: Add Device Tree bindings document for retu/tahvo ASIC chips Javier Martinez Canillas
2017-04-03 11:13   ` Lee Jones
2017-04-03 11:13     ` Lee Jones
2017-04-03 15:40     ` Javier Martinez Canillas
2017-04-01  7:18 ` [PATCH v3 2/7] mfd: retu: Add OF device ID table Javier Martinez Canillas
2017-04-03 11:15   ` Lee Jones [this message]
2017-04-03 11:15     ` Lee Jones
2017-04-03 15:45     ` Javier Martinez Canillas
2017-04-03 22:20       ` Rob Herring
2017-04-03 22:24         ` Javier Martinez Canillas
2017-04-03 22:24           ` Javier Martinez Canillas
2017-04-03 22:53           ` Aaro Koskinen
2017-04-03 22:53             ` Aaro Koskinen
2017-04-03 22:58             ` Tony Lindgren
2017-04-03 23:00               ` Javier Martinez Canillas
2017-04-03 23:00                 ` Javier Martinez Canillas
2017-04-01  7:18 ` [PATCH v3 3/7] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas
2017-04-01  7:18 ` [PATCH v3 4/7] ARM: dts: n8x0: Add vendor prefix to retu node Javier Martinez Canillas
2017-04-01  7:18   ` Javier Martinez Canillas
2017-04-01  7:18   ` Javier Martinez Canillas
2017-04-01  7:18 ` [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI tps6105x chip Javier Martinez Canillas
2017-04-01  7:18   ` Javier Martinez Canillas
2017-04-03 11:15   ` Lee Jones
2017-04-03 11:15     ` Lee Jones
2017-04-03 15:47     ` Javier Martinez Canillas
2017-04-04  8:27       ` Lee Jones
2017-04-04 11:48         ` Javier Martinez Canillas
2017-04-04 11:48           ` Javier Martinez Canillas
2017-04-01  7:18 ` [PATCH v3 6/7] mfd: tps6105x: Add OF device ID table Javier Martinez Canillas
2017-04-01  7:18 ` [PATCH v3 7/7] ARM: ux500: Add vendor prefix to tps61052 node Javier Martinez Canillas
2017-04-01  7:18   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170403111502.lotjpd746vkhekkg@dell \
    --to=lee.jones@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@osg.samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.