All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com, ptesarik@suse.com,
	daniel.kiper@oracle.com, eric.devolder@oracle.com,
	konrad.wilk@oracle.com, andrew.cooper3@citrix.com
Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()
Date: Mon, 3 Apr 2017 14:42:57 +0200	[thread overview]
Message-ID: <20170403124257.GA3439@router-fw-old.local.net-space.pl> (raw)
In-Reply-To: <20170331101438.28582-1-jgross@suse.com>

On Fri, Mar 31, 2017 at 12:14:38PM +0200, Juergen Gross wrote:
> For kdump to work correctly it needs the physical address of
> vmcoreinfo_note. When running as dom0 this means the virtual address
> has to be translated to the related machine address.
>
> paddr_vmcoreinfo_note() is meant to do the translation via
> __pa_symbol() only, but being attributed "weak" it can be replaced
> easily in Xen case.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Have you tested this patch with latest crash tool? Do dom0 and Xen
hypervisor analysis work without any issue (at least basic commands
like dmesg, bt, ps, etc.)? If yes for both you can add:

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

WARNING: multiple messages have this Message-ID
From: Daniel Kiper <dkiper@net-space.pl>
To: Juergen Gross <jgross@suse.com>
Cc: ptesarik@suse.com, andrew.cooper3@citrix.com,
	daniel.kiper@oracle.com, linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
	eric.devolder@oracle.com
Subject: Re: [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()
Date: Mon, 3 Apr 2017 14:42:57 +0200	[thread overview]
Message-ID: <20170403124257.GA3439@router-fw-old.local.net-space.pl> (raw)
In-Reply-To: <20170331101438.28582-1-jgross@suse.com>

On Fri, Mar 31, 2017 at 12:14:38PM +0200, Juergen Gross wrote:
> For kdump to work correctly it needs the physical address of
> vmcoreinfo_note. When running as dom0 this means the virtual address
> has to be translated to the related machine address.
>
> paddr_vmcoreinfo_note() is meant to do the translation via
> __pa_symbol() only, but being attributed "weak" it can be replaced
> easily in Xen case.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Have you tested this patch with latest crash tool? Do dom0 and Xen
hypervisor analysis work without any issue (at least basic commands
like dmesg, bt, ps, etc.)? If yes for both you can add:

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-04-03 12:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 10:14 [PATCH v2] xen,kdump: " Juergen Gross
2017-03-31 14:02 ` Boris Ostrovsky
2017-03-31 14:02   ` [PATCH v2] xen, kdump: " Boris Ostrovsky
2017-04-03 12:42 ` Daniel Kiper [this message]
2017-04-03 12:42   ` Daniel Kiper
2017-04-04 11:55   ` [Xen-devel] " Juergen Gross
2017-04-04 11:55   ` Juergen Gross
2017-04-11 12:45   ` Juergen Gross
2017-04-11 12:45   ` [Xen-devel] " Juergen Gross
2017-04-11 13:00     ` Daniel Kiper
2017-04-11 14:59       ` Petr Tesarik
2017-04-11 17:20         ` Daniel Kiper
2017-04-11 17:20         ` [Xen-devel] " Daniel Kiper
2017-04-14 16:53           ` Petr Tesarik
2017-04-14 16:53           ` [Xen-devel] " Petr Tesarik
2017-04-14 22:26             ` Daniel Kiper
2017-04-15 14:35               ` Petr Tesarik
2017-04-15 14:35               ` Petr Tesarik
2017-04-14 22:26             ` Daniel Kiper
2017-04-11 14:59       ` Petr Tesarik
2017-04-11 13:00     ` Daniel Kiper
2017-04-04 19:42 [Xen-devel] " Daniel Kiper
2017-04-05 11:13 ` Petr Tesarik
2017-04-07  9:16   ` Petr Tesarik
2017-04-10 20:49     ` Daniel Kiper
2017-04-11 10:49       ` Petr Tesarik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170403124257.GA3439@router-fw-old.local.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=eric.devolder@oracle.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ptesarik@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.