From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139AbdDCMtM (ORCPT ); Mon, 3 Apr 2017 08:49:12 -0400 Received: from boksu.net-space.pl ([185.15.1.105]:33836 "EHLO boksu.net-space.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416AbdDCMtK (ORCPT ); Mon, 3 Apr 2017 08:49:10 -0400 X-Greylist: delayed 329 seconds by postgrey-1.27 at vger.kernel.org; Mon, 03 Apr 2017 08:49:10 EDT Date: Mon, 3 Apr 2017 14:42:57 +0200 From: Daniel Kiper To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, ptesarik@suse.com, daniel.kiper@oracle.com, eric.devolder@oracle.com, konrad.wilk@oracle.com, andrew.cooper3@citrix.com Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() Message-ID: <20170403124257.GA3439@router-fw-old.local.net-space.pl> References: <20170331101438.28582-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170331101438.28582-1-jgross@suse.com> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 31, 2017 at 12:14:38PM +0200, Juergen Gross wrote: > For kdump to work correctly it needs the physical address of > vmcoreinfo_note. When running as dom0 this means the virtual address > has to be translated to the related machine address. > > paddr_vmcoreinfo_note() is meant to do the translation via > __pa_symbol() only, but being attributed "weak" it can be replaced > easily in Xen case. > > Signed-off-by: Juergen Gross Have you tested this patch with latest crash tool? Do dom0 and Xen hypervisor analysis work without any issue (at least basic commands like dmesg, bt, ps, etc.)? If yes for both you can add: Reviewed-by: Daniel Kiper Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Kiper Subject: Re: [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() Date: Mon, 3 Apr 2017 14:42:57 +0200 Message-ID: <20170403124257.GA3439@router-fw-old.local.net-space.pl> References: <20170331101438.28582-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cv1K7-0000Vc-5m for xen-devel@lists.xenproject.org; Mon, 03 Apr 2017 12:43:07 +0000 Received: (from localhost user: 'dkiper' uid#4000 fake: STDIN (dkiper@boksu.net-space.pl)) by router-fw-old.local.net-space.pl id S1770852AbdDCMm5 (ORCPT ); Mon, 3 Apr 2017 14:42:57 +0200 Content-Disposition: inline In-Reply-To: <20170331101438.28582-1-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross Cc: ptesarik@suse.com, andrew.cooper3@citrix.com, daniel.kiper@oracle.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, eric.devolder@oracle.com List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBNYXIgMzEsIDIwMTcgYXQgMTI6MTQ6MzhQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3 cm90ZToKPiBGb3Iga2R1bXAgdG8gd29yayBjb3JyZWN0bHkgaXQgbmVlZHMgdGhlIHBoeXNpY2Fs IGFkZHJlc3Mgb2YKPiB2bWNvcmVpbmZvX25vdGUuIFdoZW4gcnVubmluZyBhcyBkb20wIHRoaXMg bWVhbnMgdGhlIHZpcnR1YWwgYWRkcmVzcwo+IGhhcyB0byBiZSB0cmFuc2xhdGVkIHRvIHRoZSBy ZWxhdGVkIG1hY2hpbmUgYWRkcmVzcy4KPgo+IHBhZGRyX3ZtY29yZWluZm9fbm90ZSgpIGlzIG1l YW50IHRvIGRvIHRoZSB0cmFuc2xhdGlvbiB2aWEKPiBfX3BhX3N5bWJvbCgpIG9ubHksIGJ1dCBi ZWluZyBhdHRyaWJ1dGVkICJ3ZWFrIiBpdCBjYW4gYmUgcmVwbGFjZWQKPiBlYXNpbHkgaW4gWGVu IGNhc2UuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ CgpIYXZlIHlvdSB0ZXN0ZWQgdGhpcyBwYXRjaCB3aXRoIGxhdGVzdCBjcmFzaCB0b29sPyBEbyBk b20wIGFuZCBYZW4KaHlwZXJ2aXNvciBhbmFseXNpcyB3b3JrIHdpdGhvdXQgYW55IGlzc3VlIChh dCBsZWFzdCBiYXNpYyBjb21tYW5kcwpsaWtlIGRtZXNnLCBidCwgcHMsIGV0Yy4pPyBJZiB5ZXMg Zm9yIGJvdGggeW91IGNhbiBhZGQ6CgpSZXZpZXdlZC1ieTogRGFuaWVsIEtpcGVyIDxkYW5pZWwu a2lwZXJAb3JhY2xlLmNvbT4KCkRhbmllbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMu eGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==