From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbdDCOLt (ORCPT ); Mon, 3 Apr 2017 10:11:49 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34526 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752504AbdDCOLm (ORCPT ); Mon, 3 Apr 2017 10:11:42 -0400 Date: Mon, 3 Apr 2017 09:11:35 -0500 From: Rob Herring To: Russell King - ARM Linux Cc: Steve Longerbeam , Mark Rutland , Shawn Guo , "kernel@pengutronix.de" , Fabio Estevam , Mauro Carvalho Chehab , Hans Verkuil , Nick Dyer , markus.heiser@darmarit.de, Philipp Zabel , Laurent Pinchart , Benoit Parrot , Geert Uytterhoeven , Arnd Bergmann , Sudip Mukherjee , Minghsiu Tsai , tiffany lin , Jean-Christophe Trotin , Simon Horman , Niklas =?iso-8859-1?Q?S=F6derlund?= , Robert Jarzmik , Songjun Wu , Andrew-CT Chen =?utf-8?B?KOmZs+aZuui/qik=?= , Greg Kroah-Hartman , shuah@kernel.org, Sakari Ailus , Pavel Machek , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , devel@driverdev.osuosl.org, Steve Longerbeam Subject: Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver Message-ID: <20170403141135.6rwwftkiqqicmn6a@rob-hp-laptop> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-3-git-send-email-steve_longerbeam@mentor.com> <20170329083904.GZ7909@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170329083904.GZ7909@n2100.armlinux.org.uk> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2017 at 09:39:05AM +0100, Russell King - ARM Linux wrote: > On Tue, Mar 28, 2017 at 07:21:34PM -0500, Rob Herring wrote: > > On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam wrote: > > > Add bindings documentation for the i.MX media driver. > > > > > > Signed-off-by: Steve Longerbeam > > > --- > > > Documentation/devicetree/bindings/media/imx.txt | 74 +++++++++++++++++++++++++ > > > 1 file changed, 74 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/imx.txt > > > > > > diff --git a/Documentation/devicetree/bindings/media/imx.txt b/Documentation/devicetree/bindings/media/imx.txt > > > new file mode 100644 > > > index 0000000..3059c06 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/imx.txt > > > @@ -0,0 +1,74 @@ > > > +Freescale i.MX Media Video Device > > > +================================= > > > + > > > +Video Media Controller node > > > +--------------------------- > > > + > > > +This is the media controller node for video capture support. It is a > > > +virtual device that lists the camera serial interface nodes that the > > > +media device will control. > > > + > > > +Required properties: > > > +- compatible : "fsl,imx-capture-subsystem"; > > > +- ports : Should contain a list of phandles pointing to camera > > > + sensor interface ports of IPU devices > > > + > > > +example: > > > + > > > +capture-subsystem { > > > + compatible = "fsl,imx-capture-subsystem"; > > > + ports = <&ipu1_csi0>, <&ipu1_csi1>; > > > +}; > > > + > > > +fim child node > > > +-------------- > > > + > > > +This is an optional child node of the ipu_csi port nodes. If present and > > > +available, it enables the Frame Interval Monitor. Its properties can be > > > +used to modify the method in which the FIM measures frame intervals. > > > +Refer to Documentation/media/v4l-drivers/imx.rst for more info on the > > > +Frame Interval Monitor. > > > + > > > +Optional properties: > > > +- fsl,input-capture-channel: an input capture channel and channel flags, > > > + specified as . The channel number > > > + must be 0 or 1. The flags can be > > > + IRQ_TYPE_EDGE_RISING, IRQ_TYPE_EDGE_FALLING, or > > > + IRQ_TYPE_EDGE_BOTH, and specify which input > > > + capture signal edge will trigger the input > > > + capture event. If an input capture channel is > > > + specified, the FIM will use this method to > > > + measure frame intervals instead of via the EOF > > > + interrupt. The input capture method is much > > > + preferred over EOF as it is not subject to > > > + interrupt latency errors. However it requires > > > + routing the VSYNC or FIELD output signals of > > > + the camera sensor to one of the i.MX input > > > + capture pads (SD1_DAT0, SD1_DAT1), which also > > > + gives up support for SD1. > > > + > > > + > > > +mipi_csi2 node > > > +-------------- > > > + > > > +This is the device node for the MIPI CSI-2 Receiver, required for MIPI > > > +CSI-2 sensors. > > > + > > > +Required properties: > > > +- compatible : "fsl,imx6-mipi-csi2", "snps,dw-mipi-csi2"; > > > > As I mentioned in v5, there's a DW CSI2 binding in progress. This > > needs to be based on that. > > Maybe someone can provide some kind of reference to it, and it's > associated driver? Let me Google that for you (TM). The reference is in my comments on v5. Here's a reference to it [1]. [1] https://lkml.org/lkml/2017/3/20/524 > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver Date: Mon, 3 Apr 2017 09:11:35 -0500 Message-ID: <20170403141135.6rwwftkiqqicmn6a@rob-hp-laptop> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-3-git-send-email-steve_longerbeam@mentor.com> <20170329083904.GZ7909@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170329083904.GZ7909@n2100.armlinux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Russell King - ARM Linux Cc: Mark Rutland , Andrew-CT Chen =?utf-8?B?KOmZs+aZuui/qik=?= , Minghsiu Tsai , Sakari Ailus , Nick Dyer , Songjun Wu , Hans Verkuil , Pavel Machek , Robert Jarzmik , devel@driverdev.osuosl.org, markus.heiser@darmarit.de, Laurent Pinchart , shuah@kernel.org, Geert Uytterhoeven , Steve Longerbeam , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "kernel@pengutronix.de" , Arnd Bergmann , Mauro Carvalho Chehab , Benoit Parrot Steve List-Id: devicetree@vger.kernel.org On Wed, Mar 29, 2017 at 09:39:05AM +0100, Russell King - ARM Linux wrote: > On Tue, Mar 28, 2017 at 07:21:34PM -0500, Rob Herring wrote: > > On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam wrote: > > > Add bindings documentation for the i.MX media driver. > > > > > > Signed-off-by: Steve Longerbeam > > > --- > > > Documentation/devicetree/bindings/media/imx.txt | 74 +++++++++++++++++++++++++ > > > 1 file changed, 74 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/imx.txt > > > > > > diff --git a/Documentation/devicetree/bindings/media/imx.txt b/Documentation/devicetree/bindings/media/imx.txt > > > new file mode 100644 > > > index 0000000..3059c06 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/imx.txt > > > @@ -0,0 +1,74 @@ > > > +Freescale i.MX Media Video Device > > > +================================= > > > + > > > +Video Media Controller node > > > +--------------------------- > > > + > > > +This is the media controller node for video capture support. It is a > > > +virtual device that lists the camera serial interface nodes that the > > > +media device will control. > > > + > > > +Required properties: > > > +- compatible : "fsl,imx-capture-subsystem"; > > > +- ports : Should contain a list of phandles pointing to camera > > > + sensor interface ports of IPU devices > > > + > > > +example: > > > + > > > +capture-subsystem { > > > + compatible = "fsl,imx-capture-subsystem"; > > > + ports = <&ipu1_csi0>, <&ipu1_csi1>; > > > +}; > > > + > > > +fim child node > > > +-------------- > > > + > > > +This is an optional child node of the ipu_csi port nodes. If present and > > > +available, it enables the Frame Interval Monitor. Its properties can be > > > +used to modify the method in which the FIM measures frame intervals. > > > +Refer to Documentation/media/v4l-drivers/imx.rst for more info on the > > > +Frame Interval Monitor. > > > + > > > +Optional properties: > > > +- fsl,input-capture-channel: an input capture channel and channel flags, > > > + specified as . The channel number > > > + must be 0 or 1. The flags can be > > > + IRQ_TYPE_EDGE_RISING, IRQ_TYPE_EDGE_FALLING, or > > > + IRQ_TYPE_EDGE_BOTH, and specify which input > > > + capture signal edge will trigger the input > > > + capture event. If an input capture channel is > > > + specified, the FIM will use this method to > > > + measure frame intervals instead of via the EOF > > > + interrupt. The input capture method is much > > > + preferred over EOF as it is not subject to > > > + interrupt latency errors. However it requires > > > + routing the VSYNC or FIELD output signals of > > > + the camera sensor to one of the i.MX input > > > + capture pads (SD1_DAT0, SD1_DAT1), which also > > > + gives up support for SD1. > > > + > > > + > > > +mipi_csi2 node > > > +-------------- > > > + > > > +This is the device node for the MIPI CSI-2 Receiver, required for MIPI > > > +CSI-2 sensors. > > > + > > > +Required properties: > > > +- compatible : "fsl,imx6-mipi-csi2", "snps,dw-mipi-csi2"; > > > > As I mentioned in v5, there's a DW CSI2 binding in progress. This > > needs to be based on that. > > Maybe someone can provide some kind of reference to it, and it's > associated driver? Let me Google that for you (TM). The reference is in my comments on v5. Here's a reference to it [1]. [1] https://lkml.org/lkml/2017/3/20/524 > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Mon, 3 Apr 2017 09:11:35 -0500 Subject: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver In-Reply-To: <20170329083904.GZ7909@n2100.armlinux.org.uk> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-3-git-send-email-steve_longerbeam@mentor.com> <20170329083904.GZ7909@n2100.armlinux.org.uk> Message-ID: <20170403141135.6rwwftkiqqicmn6a@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 29, 2017 at 09:39:05AM +0100, Russell King - ARM Linux wrote: > On Tue, Mar 28, 2017 at 07:21:34PM -0500, Rob Herring wrote: > > On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam wrote: > > > Add bindings documentation for the i.MX media driver. > > > > > > Signed-off-by: Steve Longerbeam > > > --- > > > Documentation/devicetree/bindings/media/imx.txt | 74 +++++++++++++++++++++++++ > > > 1 file changed, 74 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/imx.txt > > > > > > diff --git a/Documentation/devicetree/bindings/media/imx.txt b/Documentation/devicetree/bindings/media/imx.txt > > > new file mode 100644 > > > index 0000000..3059c06 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/imx.txt > > > @@ -0,0 +1,74 @@ > > > +Freescale i.MX Media Video Device > > > +================================= > > > + > > > +Video Media Controller node > > > +--------------------------- > > > + > > > +This is the media controller node for video capture support. It is a > > > +virtual device that lists the camera serial interface nodes that the > > > +media device will control. > > > + > > > +Required properties: > > > +- compatible : "fsl,imx-capture-subsystem"; > > > +- ports : Should contain a list of phandles pointing to camera > > > + sensor interface ports of IPU devices > > > + > > > +example: > > > + > > > +capture-subsystem { > > > + compatible = "fsl,imx-capture-subsystem"; > > > + ports = <&ipu1_csi0>, <&ipu1_csi1>; > > > +}; > > > + > > > +fim child node > > > +-------------- > > > + > > > +This is an optional child node of the ipu_csi port nodes. If present and > > > +available, it enables the Frame Interval Monitor. Its properties can be > > > +used to modify the method in which the FIM measures frame intervals. > > > +Refer to Documentation/media/v4l-drivers/imx.rst for more info on the > > > +Frame Interval Monitor. > > > + > > > +Optional properties: > > > +- fsl,input-capture-channel: an input capture channel and channel flags, > > > + specified as . The channel number > > > + must be 0 or 1. The flags can be > > > + IRQ_TYPE_EDGE_RISING, IRQ_TYPE_EDGE_FALLING, or > > > + IRQ_TYPE_EDGE_BOTH, and specify which input > > > + capture signal edge will trigger the input > > > + capture event. If an input capture channel is > > > + specified, the FIM will use this method to > > > + measure frame intervals instead of via the EOF > > > + interrupt. The input capture method is much > > > + preferred over EOF as it is not subject to > > > + interrupt latency errors. However it requires > > > + routing the VSYNC or FIELD output signals of > > > + the camera sensor to one of the i.MX input > > > + capture pads (SD1_DAT0, SD1_DAT1), which also > > > + gives up support for SD1. > > > + > > > + > > > +mipi_csi2 node > > > +-------------- > > > + > > > +This is the device node for the MIPI CSI-2 Receiver, required for MIPI > > > +CSI-2 sensors. > > > + > > > +Required properties: > > > +- compatible : "fsl,imx6-mipi-csi2", "snps,dw-mipi-csi2"; > > > > As I mentioned in v5, there's a DW CSI2 binding in progress. This > > needs to be based on that. > > Maybe someone can provide some kind of reference to it, and it's > associated driver? Let me Google that for you (TM). The reference is in my comments on v5. Here's a reference to it [1]. [1] https://lkml.org/lkml/2017/3/20/524 > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net.