From: Andrew Morton <akpm@linux-foundation.org>
To: Alexander Polakov <apolyakov@beget.ru>
Cc: linux-mm@kvack.org, Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH] Fix print order in show_free_areas()
Date: Mon, 3 Apr 2017 15:11:11 -0700 [thread overview]
Message-ID: <20170403151111.4c9967329d6d6140e2a652ff@linux-foundation.org> (raw)
In-Reply-To: <1490377730.30219.2.camel@beget.ru>
On Fri, 24 Mar 2017 20:48:50 +0300 Alexander Polakov <apolyakov@beget.ru> wrote:
> Better seen in context: https://github.com/torvalds/linux/blob/master/m
> m/page_alloc.c#L4500
>
> Signed-off-by: Alexander Polyakov <apolyakov@beget.com>
--- a/mm/page_alloc.c~fix-print-order-in-show_free_areas
+++ a/mm/page_alloc.c
@@ -4519,13 +4519,13 @@ void show_free_areas(unsigned int filter
K(node_page_state(pgdat, NR_FILE_MAPPED)),
K(node_page_state(pgdat, NR_FILE_DIRTY)),
K(node_page_state(pgdat, NR_WRITEBACK)),
+ K(node_page_state(pgdat, NR_SHMEM)),
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR),
K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED)
* HPAGE_PMD_NR),
K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR),
#endif
- K(node_page_state(pgdat, NR_SHMEM)),
K(node_page_state(pgdat, NR_WRITEBACK_TEMP)),
K(node_page_state(pgdat, NR_UNSTABLE_NFS)),
node_page_state(pgdat, NR_PAGES_SCANNED),
_
huh. It looks like this has been broken for nearly a year, by
: commit 11fb998986a72aa7e997d96d63d52582a01228c5
: Author: Mel Gorman <mgorman@techsingularity.net>
: AuthorDate: Thu Jul 28 15:46:20 2016 -0700
: Commit: Linus Torvalds <torvalds@linux-foundation.org>
: CommitDate: Thu Jul 28 16:07:41 2016 -0700
:
: mm: move most file-based accounting to the node
I'm surprised nobody noticed until now.
btw, your email client is messing up the patches: tabs are getting
mangled and wordwrapping is added. Please fix that up for next time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-04-03 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 17:48 [PATCH] Fix print order in show_free_areas() Alexander Polakov
2017-04-03 22:11 ` Andrew Morton [this message]
2017-04-04 14:19 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403151111.4c9967329d6d6140e2a652ff@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apolyakov@beget.ru \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.