From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753599AbdDCPQN (ORCPT ); Mon, 3 Apr 2017 11:16:13 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:45636 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbdDCPQK (ORCPT ); Mon, 3 Apr 2017 11:16:10 -0400 Date: Mon, 3 Apr 2017 16:15:11 +0100 From: Russell King - ARM Linux To: Rob Herring Cc: Steve Longerbeam , Steve Longerbeam , Mark Rutland , Shawn Guo , "kernel@pengutronix.de" , Fabio Estevam , Mauro Carvalho Chehab , Hans Verkuil , Nick Dyer , markus.heiser@darmarit.de, Philipp Zabel , Laurent Pinchart , Benoit Parrot , Geert Uytterhoeven , Arnd Bergmann , Sudip Mukherjee , Minghsiu Tsai , tiffany lin , Jean-Christophe Trotin , Simon Horman , Niklas =?iso-8859-1?Q?S=F6derlund?= , Robert Jarzmik , Songjun Wu , Andrew-CT Chen =?utf-8?B?KOmZs+aZuui/qik=?= , Greg Kroah-Hartman , shuah@kernel.org, Sakari Ailus , Pavel Machek , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , devel@driverdev.osuosl.org Subject: Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver Message-ID: <20170403151511.GA7909@n2100.armlinux.org.uk> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-3-git-send-email-steve_longerbeam@mentor.com> <70bacfb5-aef1-76d1-37d2-23a524903d45@mentor.com> <20170403140743.trxep36s4z4piyl3@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170403140743.trxep36s4z4piyl3@rob-hp-laptop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 03, 2017 at 09:07:43AM -0500, Rob Herring wrote: > On Tue, Mar 28, 2017 at 05:35:52PM -0700, Steve Longerbeam wrote: > > I assume if there's another binding doc in progress, it means > > someone is working on another Synopsys DW CSI-2 subdevice driver. > > Yes. see http://patchwork.ozlabs.org/patch/736177/ > > > Unfortunately I don't have the time to contribute and switch to > > this other subdevice, and do test/debug. > > >From a DT perspective, I'm not asking that you share the subdevice > driver, only the binding. Simply put, there's 1 h/w block here, so there > should only be 1 binding. The binding is an ABI, so you can't just merge > it and change it later. I think it would be nice to have some kind of standard base binding for CSI2 interfaces, but beyond the standard compatible/reg/interrupts and graph properties, I'm not sure what it would look like. As far as those properties go, the iMX6 version does better than the DW version, because we specify the full graph, whereas the DW version only specifies the downstream link. Once that's done, there's some properties (like those specifying the output configuration) which probably ought to be moved to the graph links instead, once they exist. So, if anything, I think it's the DW version needs to be augmented with fuller information, and some of the properties moved. Also, as I've mentioned in my other reply, while they may both appear to be called "Synopsys DW CSI-2" devices, they appear to be quite different from the hardware perspective. The rest -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver Date: Mon, 3 Apr 2017 16:15:11 +0100 Message-ID: <20170403151511.GA7909@n2100.armlinux.org.uk> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-3-git-send-email-steve_longerbeam@mentor.com> <70bacfb5-aef1-76d1-37d2-23a524903d45@mentor.com> <20170403140743.trxep36s4z4piyl3@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170403140743.trxep36s4z4piyl3@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Steve Longerbeam , Steve Longerbeam , Mark Rutland , Shawn Guo , "kernel@pengutronix.de" , Fabio Estevam , Mauro Carvalho Chehab , Hans Verkuil , Nick Dyer , markus.heiser@darmarit.de, Philipp Zabel , Laurent Pinchart , Benoit Parrot , Geert Uytterhoeven , Arnd Bergmann , Sudip Mukherjee , Minghsiu Tsai , tiffany lin , Jean-Christophe Trotin List-Id: devicetree@vger.kernel.org On Mon, Apr 03, 2017 at 09:07:43AM -0500, Rob Herring wrote: > On Tue, Mar 28, 2017 at 05:35:52PM -0700, Steve Longerbeam wrote: > > I assume if there's another binding doc in progress, it means > > someone is working on another Synopsys DW CSI-2 subdevice driver. > > Yes. see http://patchwork.ozlabs.org/patch/736177/ > > > Unfortunately I don't have the time to contribute and switch to > > this other subdevice, and do test/debug. > > >From a DT perspective, I'm not asking that you share the subdevice > driver, only the binding. Simply put, there's 1 h/w block here, so there > should only be 1 binding. The binding is an ABI, so you can't just merge > it and change it later. I think it would be nice to have some kind of standard base binding for CSI2 interfaces, but beyond the standard compatible/reg/interrupts and graph properties, I'm not sure what it would look like. As far as those properties go, the iMX6 version does better than the DW version, because we specify the full graph, whereas the DW version only specifies the downstream link. Once that's done, there's some properties (like those specifying the output configuration) which probably ought to be moved to the graph links instead, once they exist. So, if anything, I think it's the DW version needs to be augmented with fuller information, and some of the properties moved. Also, as I've mentioned in my other reply, while they may both appear to be called "Synopsys DW CSI-2" devices, they appear to be quite different from the hardware perspective. The rest -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Mon, 3 Apr 2017 16:15:11 +0100 Subject: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver In-Reply-To: <20170403140743.trxep36s4z4piyl3@rob-hp-laptop> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-3-git-send-email-steve_longerbeam@mentor.com> <70bacfb5-aef1-76d1-37d2-23a524903d45@mentor.com> <20170403140743.trxep36s4z4piyl3@rob-hp-laptop> Message-ID: <20170403151511.GA7909@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 03, 2017 at 09:07:43AM -0500, Rob Herring wrote: > On Tue, Mar 28, 2017 at 05:35:52PM -0700, Steve Longerbeam wrote: > > I assume if there's another binding doc in progress, it means > > someone is working on another Synopsys DW CSI-2 subdevice driver. > > Yes. see http://patchwork.ozlabs.org/patch/736177/ > > > Unfortunately I don't have the time to contribute and switch to > > this other subdevice, and do test/debug. > > >From a DT perspective, I'm not asking that you share the subdevice > driver, only the binding. Simply put, there's 1 h/w block here, so there > should only be 1 binding. The binding is an ABI, so you can't just merge > it and change it later. I think it would be nice to have some kind of standard base binding for CSI2 interfaces, but beyond the standard compatible/reg/interrupts and graph properties, I'm not sure what it would look like. As far as those properties go, the iMX6 version does better than the DW version, because we specify the full graph, whereas the DW version only specifies the downstream link. Once that's done, there's some properties (like those specifying the output configuration) which probably ought to be moved to the graph links instead, once they exist. So, if anything, I think it's the DW version needs to be augmented with fuller information, and some of the properties moved. Also, as I've mentioned in my other reply, while they may both appear to be called "Synopsys DW CSI-2" devices, they appear to be quite different from the hardware perspective. The rest -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.