From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753863AbdDCP7X (ORCPT ); Mon, 3 Apr 2017 11:59:23 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:38305 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752760AbdDCP7V (ORCPT ); Mon, 3 Apr 2017 11:59:21 -0400 Date: Mon, 3 Apr 2017 17:59:09 +0200 From: Alexandre Belloni To: Ludovic Desroches Cc: linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dmitry.torokhov@gmail.com, nicolas.ferre@microchip.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] dt-bindings: input: Add Atmel PTC subsystem bindings Message-ID: <20170403155909.wbo4f4x3agqtim5c@piout.net> References: <20170331152250.12758-1-ludovic.desroches@microchip.com> <20170331152250.12758-5-ludovic.desroches@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170331152250.12758-5-ludovic.desroches@microchip.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I think this patch should be first so you add the bindings before the driver. On 31/03/2017 at 17:22:50 +0200, Ludovic Desroches wrote: > Add description of the Atmel PTC subsystem bindings. > > Signed-off-by: Ludovic Desroches > --- > .../devicetree/bindings/input/atmel,ptc.txt | 67 ++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/atmel,ptc.txt > > diff --git a/Documentation/devicetree/bindings/input/atmel,ptc.txt b/Documentation/devicetree/bindings/input/atmel,ptc.txt > new file mode 100644 > index 0000000..a183fd5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/atmel,ptc.txt > @@ -0,0 +1,67 @@ > +Atmel PTC Subsystem > + > +The Atmel Peripheral Touch Controller subsystem offers built-in hardware > +for capacitive touch measurement on sensors that function as buttons, sliders > +and wheels. > + > +1) PTC Subsystem node > + > +Required properties: > +- compatible: Must be "atmel,sama5d2-ptc" > +- reg: Address, length of the shared memory and ppp registers location > + and length. > +- clocks: Phandlers to the clocks. > +- clock-names: Must be "ptc_clk", "ptc_int_osc", "slow_clk". > +- #address-cells: Must be one. The cell is the button or scroller id. > +- #size-cells: Must be zero. > + > +Example: > + ptc@fc060000 { > + compatible = "atmel,sama5d2-ptc"; > + reg = <0x00800000 0x10000 > + 0xfc060000 0xcf>; > + interrupts = <58 IRQ_TYPE_LEVEL_HIGH 7>; > + clocks = <&ptc_clk>, <&main>, <&clk32k>; > + clock-names = "ptc_clk", "ptc_int_osc", "slow_clk"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + [ child node definitions... ] > + }; > + > +2) Scroller / buttons subnodes > + > +Subnodes describe the kind of sensors the customer want to use. They have to be > +named according to their function: button, slider or wheel. > + > +2.1) Scroller subnodes > + > +Required properties: > +- reg: Id of the scroller, each id must be different. > + > +Example: > + slider@0 { > + reg = <0>; > + }; > + > + wheel@1 { > + reg = <1>; > + }; > + > +2.2) Button subnodes > + > +Required properties: > +- reg: Id of node used for the button, each id must be > + different. > +- linux,keycode: Key code of the button. > + > +Example: > + button@8 { > + reg = <8>; > + linux,keycode = <2>; > + }; > + > + button@9 { > + reg = <9>; > + linux,keycode = <3>; > + }; > -- > 2.9.0 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 4/4] dt-bindings: input: Add Atmel PTC subsystem bindings Date: Mon, 3 Apr 2017 17:59:09 +0200 Message-ID: <20170403155909.wbo4f4x3agqtim5c@piout.net> References: <20170331152250.12758-1-ludovic.desroches@microchip.com> <20170331152250.12758-5-ludovic.desroches@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170331152250.12758-5-ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ludovic Desroches Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org I think this patch should be first so you add the bindings before the driver. On 31/03/2017 at 17:22:50 +0200, Ludovic Desroches wrote: > Add description of the Atmel PTC subsystem bindings. > > Signed-off-by: Ludovic Desroches > --- > .../devicetree/bindings/input/atmel,ptc.txt | 67 ++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/atmel,ptc.txt > > diff --git a/Documentation/devicetree/bindings/input/atmel,ptc.txt b/Documentation/devicetree/bindings/input/atmel,ptc.txt > new file mode 100644 > index 0000000..a183fd5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/atmel,ptc.txt > @@ -0,0 +1,67 @@ > +Atmel PTC Subsystem > + > +The Atmel Peripheral Touch Controller subsystem offers built-in hardware > +for capacitive touch measurement on sensors that function as buttons, sliders > +and wheels. > + > +1) PTC Subsystem node > + > +Required properties: > +- compatible: Must be "atmel,sama5d2-ptc" > +- reg: Address, length of the shared memory and ppp registers location > + and length. > +- clocks: Phandlers to the clocks. > +- clock-names: Must be "ptc_clk", "ptc_int_osc", "slow_clk". > +- #address-cells: Must be one. The cell is the button or scroller id. > +- #size-cells: Must be zero. > + > +Example: > + ptc@fc060000 { > + compatible = "atmel,sama5d2-ptc"; > + reg = <0x00800000 0x10000 > + 0xfc060000 0xcf>; > + interrupts = <58 IRQ_TYPE_LEVEL_HIGH 7>; > + clocks = <&ptc_clk>, <&main>, <&clk32k>; > + clock-names = "ptc_clk", "ptc_int_osc", "slow_clk"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + [ child node definitions... ] > + }; > + > +2) Scroller / buttons subnodes > + > +Subnodes describe the kind of sensors the customer want to use. They have to be > +named according to their function: button, slider or wheel. > + > +2.1) Scroller subnodes > + > +Required properties: > +- reg: Id of the scroller, each id must be different. > + > +Example: > + slider@0 { > + reg = <0>; > + }; > + > + wheel@1 { > + reg = <1>; > + }; > + > +2.2) Button subnodes > + > +Required properties: > +- reg: Id of node used for the button, each id must be > + different. > +- linux,keycode: Key code of the button. > + > +Example: > + button@8 { > + reg = <8>; > + linux,keycode = <2>; > + }; > + > + button@9 { > + reg = <9>; > + linux,keycode = <3>; > + }; > -- > 2.9.0 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Mon, 3 Apr 2017 17:59:09 +0200 Subject: [PATCH 4/4] dt-bindings: input: Add Atmel PTC subsystem bindings In-Reply-To: <20170331152250.12758-5-ludovic.desroches@microchip.com> References: <20170331152250.12758-1-ludovic.desroches@microchip.com> <20170331152250.12758-5-ludovic.desroches@microchip.com> Message-ID: <20170403155909.wbo4f4x3agqtim5c@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org I think this patch should be first so you add the bindings before the driver. On 31/03/2017 at 17:22:50 +0200, Ludovic Desroches wrote: > Add description of the Atmel PTC subsystem bindings. > > Signed-off-by: Ludovic Desroches > --- > .../devicetree/bindings/input/atmel,ptc.txt | 67 ++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/atmel,ptc.txt > > diff --git a/Documentation/devicetree/bindings/input/atmel,ptc.txt b/Documentation/devicetree/bindings/input/atmel,ptc.txt > new file mode 100644 > index 0000000..a183fd5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/atmel,ptc.txt > @@ -0,0 +1,67 @@ > +Atmel PTC Subsystem > + > +The Atmel Peripheral Touch Controller subsystem offers built-in hardware > +for capacitive touch measurement on sensors that function as buttons, sliders > +and wheels. > + > +1) PTC Subsystem node > + > +Required properties: > +- compatible: Must be "atmel,sama5d2-ptc" > +- reg: Address, length of the shared memory and ppp registers location > + and length. > +- clocks: Phandlers to the clocks. > +- clock-names: Must be "ptc_clk", "ptc_int_osc", "slow_clk". > +- #address-cells: Must be one. The cell is the button or scroller id. > +- #size-cells: Must be zero. > + > +Example: > + ptc at fc060000 { > + compatible = "atmel,sama5d2-ptc"; > + reg = <0x00800000 0x10000 > + 0xfc060000 0xcf>; > + interrupts = <58 IRQ_TYPE_LEVEL_HIGH 7>; > + clocks = <&ptc_clk>, <&main>, <&clk32k>; > + clock-names = "ptc_clk", "ptc_int_osc", "slow_clk"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + [ child node definitions... ] > + }; > + > +2) Scroller / buttons subnodes > + > +Subnodes describe the kind of sensors the customer want to use. They have to be > +named according to their function: button, slider or wheel. > + > +2.1) Scroller subnodes > + > +Required properties: > +- reg: Id of the scroller, each id must be different. > + > +Example: > + slider at 0 { > + reg = <0>; > + }; > + > + wheel at 1 { > + reg = <1>; > + }; > + > +2.2) Button subnodes > + > +Required properties: > +- reg: Id of node used for the button, each id must be > + different. > +- linux,keycode: Key code of the button. > + > +Example: > + button at 8 { > + reg = <8>; > + linux,keycode = <2>; > + }; > + > + button at 9 { > + reg = <9>; > + linux,keycode = <3>; > + }; > -- > 2.9.0 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com