From: Mark Brown <broonie@kernel.org>
To: Jeremy Linton <lintonrjeremy@gmail.com>
Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
puck.chen@hisilicon.com, lee.jones@linaro.org
Subject: Re: [PATCH v2 2/2] regulator: hi655x: Bump parent pmic module use count
Date: Mon, 3 Apr 2017 18:19:12 +0100 [thread overview]
Message-ID: <20170403171912.uv3b3sqfw5zaoyk7@sirena.org.uk> (raw)
In-Reply-To: <20170403052843.12711-3-lintonrjeremy@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Mon, Apr 03, 2017 at 12:28:43AM -0500, Jeremy Linton wrote:
> The hi655x-regulator driver depends on the parent pmic/mfc
> device driver but doesn't increase its use count. This results
> in system crashes if the parent module is unloaded while the
> regulators are still in use. Add explicit module get/put
> calls to keep the parent from being unloaded.
Once again, it is a complete hack to do this at the individual driver
level. Please don't ignore review feedback.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2017-04-03 17:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 5:28 [PATCH v2 0/2] Hi655x: mfd/pmic: regulator: Correct dependencies Jeremy Linton
2017-04-03 5:28 ` [PATCH v2 1/2] regulator: hi655x: Describe consumed platform device Jeremy Linton
2017-04-04 12:23 ` Applied "regulator: hi655x: Describe consumed platform device" to the regulator tree Mark Brown
2017-04-03 5:28 ` [PATCH v2 2/2] regulator: hi655x: Bump parent pmic module use count Jeremy Linton
2017-04-03 17:19 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403171912.uv3b3sqfw5zaoyk7@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=lintonrjeremy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.