From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbdDCWUR (ORCPT ); Mon, 3 Apr 2017 18:20:17 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35460 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbdDCWUM (ORCPT ); Mon, 3 Apr 2017 18:20:12 -0400 Date: Mon, 3 Apr 2017 17:20:10 -0500 From: Rob Herring To: Javier Martinez Canillas Cc: Lee Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table Message-ID: <20170403222010.xgbf7imyieyfroqr@rob-hp-laptop> References: <20170401071854.23198-1-javier@osg.samsung.com> <20170401071854.23198-3-javier@osg.samsung.com> <20170403111502.lotjpd746vkhekkg@dell> <2147b8c9-02ee-1b9c-a74e-119b0b73d1d7@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2147b8c9-02ee-1b9c-a74e-119b0b73d1d7@osg.samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 03, 2017 at 11:45:14AM -0400, Javier Martinez Canillas wrote: > Hello Lee, > > On 04/03/2017 07:15 AM, Lee Jones wrote: > > [snip] > > >> > >> +static const struct of_device_id retu_of_match[] = { > >> + { .compatible = "nokia,retu-mfd" }, > >> + { .compatible = "nokia,tahvo-mfd" }, > > > > Please drop the "-mfd". > > > > Yes, I also didn't like it but I didn't want to change it since that would > mean that backward compatiblity and bisect-ability will be broken by this > change. > > In other words, just adding a vendor prefix won't cause an issue if patches > are merged independently since if DTS patches are merged before, the driver > will still lookup using the I2C device ID table. And if the drivers patches > are picked before, the DTS will match using the OF device ID table. > > But changing to "nokia,retu" and "nokia,tahvo" means that you will need to > pick all patches and also that the DTS and drivers changes will have to be > done in the same patch. If you are OK with that, then I can change in the > next version. tahvo is not documented nor used in any dts (in the kernel at least). retu is used by 1 board and happened to work, but was never documented. So I think it is okay to change unless the N800 folks object. Rob