Re: [PATCH] platform/x86: asus-nb-wmi: Add wapf=4 quirk for Asus X302UA

Re: [PATCH] platform/x86: asus-nb-wmi: Add wapf=4 quirk for Asus X302UA

[Darren Hart]

On Thu, Mar 30, 2017 at 09:02:41PM +0300, Santeri Toivonen wrote:
> Asus laptop X302UA starts up with wifi hard-blocked without any meaningful
> way to enable it.
> Setting wapf=4 fixes the problem.

Please always Cc LKML and all listed maintainers and lists when submitting
patches to the Linux kernel (according to get_maintainer.pl).

(Didn't add LKML since the original has HTML)
+Andy

> 
> Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index dea98ffb6f60..1ae58d906536 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = {
>   },
>   {
>   .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. X302UA",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"),
> + },
> + .driver_data = &quirk_asus_wapf4,
> + },
> + {
> + .callback = dmi_matched,

The change looks good in general, with the exception of the whitespace
corruption. Indentation should match the surrounding similar dmi match blocks,
using tabs.

This message contains multiple content types, including one in HTML, which LKML
will drop.

Please see: Documentation/process/submitting-patches.rst
       and: Documentation/process/email-clients.rst

If you need assistance getting the patch submitted correctly, I'll be happy to
help. This appears to be a mail client induced whitespace corruption issue and
embedded HTML problem. See the email-clients.rst document for ways to resolve
this.

Thanks,

-- 
Darren Hart
VMware Open Source Technology Center

Re: [PATCH] platform/x86: asus-nb-wmi: Add wapf=4 quirk for Asus X302UA

[Jala -]

The issue should be corrected in the following.

---
 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index dea98ffb6f60..1ae58d906536 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = {
  },
  {
  .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. X302UA",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"),
+ },
+ .driver_data = &quirk_asus_wapf4,
+ },
+ {
+ .callback = dmi_matched,
  .ident = "ASUSTeK COMPUTER INC. X401U",
  .matches = {
  DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
2.11.0.windows.3

Re: [PATCH] platform/x86: asus-nb-wmi: Add wapf=4 quirk for Asus X302UA

[Andy Shevchenko]

On Tue, 2017-04-04 at 13:14 +0300, Jala - wrote:
> The issue should be corrected in the following.
> 

You need to add your Signed-off-by line here with your Real Name.

Usually you may achieve this by passing -s when do git commit

Example:
% git commit -a -s

Before doing this you need to configure your credentials in global or
local configuration file:

% git config --global user.name "Real Name"
% git config --global user.email "real.name@domain.com"


> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index dea98ffb6f60..1ae58d906536 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] =
> {
>   },
>   {
>   .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. X302UA",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"),
> + },
> + .driver_data = &quirk_asus_wapf4,
> + },
> + {
> + .callback = dmi_matched,

Now here.
As Darren already said to you you need to properly indent strings like
	.matches = {
		DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
and alike.

Looking closer to the mail I would suggest to check your mail client and
gateway that they do not mangle the message body.

And, if you are doing this manually, better to use special tool, i.e.
git-send-email instead.

>   .ident = "ASUSTeK COMPUTER INC. X401U",
>   .matches = {
>   DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Re: [PATCH] platform/x86: asus-nb-wmi: Add wapf=4 quirk for Asus X302UA

[Santeri Toivonen]

On 4.4.2017 14:44, Andy Shevchenko wrote:
> On Tue, 2017-04-04 at 13:14 +0300, Jala - wrote:
>> The issue should be corrected in the following.
>>
>
> You need to add your Signed-off-by line here with your Real Name.
>
> Usually you may achieve this by passing -s when do git commit
>
> Example:
> % git commit -a -s
>
> Before doing this you need to configure your credentials in global or
> local configuration file:
>
> % git config --global user.name "Real Name"
> % git config --global user.email "real.name@domain.com"
>
>
>> ---
>>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/platform/x86/asus-nb-wmi.c
>> b/drivers/platform/x86/asus-nb-wmi.c
>> index dea98ffb6f60..1ae58d906536 100644
>> --- a/drivers/platform/x86/asus-nb-wmi.c
>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>> @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] =
>> {
>>   },
>>   {
>>   .callback = dmi_matched,
>> + .ident = "ASUSTeK COMPUTER INC. X302UA",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"),
>> + },
>> + .driver_data = &quirk_asus_wapf4,
>> + },
>> + {
>> + .callback = dmi_matched,
>
> Now here.
> As Darren already said to you you need to properly indent strings like
> 	.matches = {
> 		DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> and alike.
>
> Looking closer to the mail I would suggest to check your mail client and
> gateway that they do not mangle the message body.
>
> And, if you are doing this manually, better to use special tool, i.e.
> git-send-email instead.
>
>>   .ident = "ASUSTeK COMPUTER INC. X401U",
>>   .matches = {
>>   DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>

There were indeed some issues wit hthe mail client ruining the 
formatting which should finally be fixed in the following:

Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com>
---
  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c 
b/drivers/platform/x86/asus-nb-wmi.c
index dea98ffb6f60..1ae58d906536 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = {
  	},
  	{
  		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X302UA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"),
+		},
+		.driver_data = &quirk_asus_wapf4,
+	},
+	{
+		.callback = dmi_matched,
  		.ident = "ASUSTeK COMPUTER INC. X401U",
  		.matches = {
  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
2.11.0.windows.3

Re: [PATCH] platform/x86: asus-nb-wmi: Add wapf=4 quirk for Asus X302UA

[Andy Shevchenko]

On Tue, Apr 4, 2017 at 4:35 PM, Santeri Toivonen
<santeri.toivonen@vatsul.com> wrote:

> There were indeed some issues wit hthe mail client ruining the formatting
> which should finally be fixed in the following:

Now, patch looks indeed good.Though I need a better commit message.
Please, resend
- as a separate mail
- having clear commit message.

Thanks!

>
> Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index dea98ffb6f60..1ae58d906536 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = {
>         },
>         {
>                 .callback = dmi_matched,
> +               .ident = "ASUSTeK COMPUTER INC. X302UA",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"),
> +               },
> +               .driver_data = &quirk_asus_wapf4,
> +       },
> +       {
> +               .callback = dmi_matched,
>                 .ident = "ASUSTeK COMPUTER INC. X401U",
>                 .matches = {
>                         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> --
> 2.11.0.windows.3



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: asus-nb-wmi: Add wapf=4 quirk for Asus X302UA

[Darren Hart]

On Tue, Apr 04, 2017 at 01:14:36PM +0300, Jala - wrote:
> The issue should be corrected in the following.

Unfortunately not. See the body of the message and note that there are no
leading tabs in the DMI_MATCH block.

I recommend sending the message to yourself and attempting to apply the patch.
Once that works, send it to the list.

If you aren't sure how to resolve the problem after reading the Documentation I
linked to, feel free to reach out to me privately for assistance.

Regards,

-- 
Darren Hart
VMware Open Source Technology Center

> 
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index dea98ffb6f60..1ae58d906536 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = {
>   },
>   {
>   .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. X302UA",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"),
> + },
> + .driver_data = &quirk_asus_wapf4,
> + },
> + {
> + .callback = dmi_matched,
>   .ident = "ASUSTeK COMPUTER INC. X401U",
>   .matches = {
>   DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> -- 
> 2.11.0.windows.3
>