From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752248AbdDDCBA (ORCPT ); Mon, 3 Apr 2017 22:01:00 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35181 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751362AbdDDCA6 (ORCPT ); Mon, 3 Apr 2017 22:00:58 -0400 Date: Mon, 3 Apr 2017 21:00:56 -0500 From: Rob Herring To: Guillaume Tucker Cc: Mark Rutland , Sjoerd Simons , Enric Balletbo i Serra , John Reitan , Wookey , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] dt-bindings: gpu: add bindings for the ARM Mali Midgard GPU Message-ID: <20170404020056.d7osj7rmog22xbjd@rob-hp-laptop> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 02, 2017 at 08:59:44AM +0100, Guillaume Tucker wrote: > The ARM Mali Midgard GPU family is present in a number of SoCs > from many different vendors such as Samsung Exynos and Rockchip. > > Import the device tree bindings documentation from the r16p0 > release of the Mali Midgard GPU kernel driver: > > https://developer.arm.com/-/media/Files/downloads/mali-drivers/kernel/mali-midgard-gpu/TX011-SW-99002-r16p0-00rel0.tgz > > The following optional bindings have been omitted in this initial > version as they are only used in very specific cases: > > * snoop_enable_smc > * snoop_disable_smc > * jm_config > * power_model > * system-coherency > * ipa-model > > The example has been simplified accordingly. > > The compatible string definition has been limited to > "arm,mali-midgard" to avoid checkpatch.pl warnings and to match > what the driver actually expects (as of r16p0 out-of-tree). > > CC: John Reitan > Signed-off-by: Guillaume Tucker > --- > .../devicetree/bindings/gpu/arm,mali-midgard.txt | 53 ++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > new file mode 100644 > index 000000000000..da8fc6d21bbf > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -0,0 +1,53 @@ > +# > +# (C) COPYRIGHT 2013-2016 ARM Limited. > +# Copyright (C) 2017 Collabora Ltd > +# > +# This program is free software and is provided to you under the terms of the > +# GNU General Public License version 2 as published by the Free Software > +# Foundation, and any use by you of this program is subject to the terms > +# of such GNU licence. > +# > + > + > +ARM Mali Midgard GPU > +==================== > + > +Required properties: > + > +- compatible : Should be "arm,mali-midgard". As Neil said... > +- reg : Physical base address of the device and length of the register area. > +- interrupts : Contains the three IRQ lines required by Mali Midgard devices. > +- interrupt-names : Contains the names of IRQ resources in the order they were > + provided in the interrupts property. Must contain: "JOB, "MMU", "GPU". > + > +Optional: > + > +- clocks : Phandle to clock for the Mali Midgard device. > +- clock-names : Shall be "clk_mali". "clk_" is redundant. Actually, if there is only 1 clock, then just drop names. But there's not at least a core and bus clock? > +- mali-supply : Phandle to regulator for the Mali device. Refer to > + Documentation/devicetree/bindings/regulator/regulator.txt for details. > +- operating-points : Refer to Documentation/devicetree/bindings/power/opp.txt > + for details. Is this going to be sufficient vs. operating-points-v2? Or should it be a power domain with OPPs? > + > +Example for a Mali-T602: > + > +gpu@0xfc010000 { Drop the '0x'. > + compatible = "arm,mali-midgard"; > + reg = <0xfc010000 0x4000>; > + interrupts = <0 36 4>, <0 37 4>, <0 38 4>; > + interrupt-names = "JOB", "MMU", "GPU"; > + > + clocks = <&pclk_mali>; > + clock-names = "clk_mali"; > + mali-supply = <&vdd_mali>; > + operating-points = < > + /* KHz uV */ > + 533000 1250000, > + 450000 1150000, > + 400000 1125000, > + 350000 1075000, > + 266000 1025000, > + 160000 925000, > + 100000 912500, > + >; > +}; > -- > 2.11.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/5] dt-bindings: gpu: add bindings for the ARM Mali Midgard GPU Date: Mon, 3 Apr 2017 21:00:56 -0500 Message-ID: <20170404020056.d7osj7rmog22xbjd@rob-hp-laptop> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guillaume Tucker Cc: Mark Rutland , Sjoerd Simons , Enric Balletbo i Serra , John Reitan , Wookey , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, Apr 02, 2017 at 08:59:44AM +0100, Guillaume Tucker wrote: > The ARM Mali Midgard GPU family is present in a number of SoCs > from many different vendors such as Samsung Exynos and Rockchip. > > Import the device tree bindings documentation from the r16p0 > release of the Mali Midgard GPU kernel driver: > > https://developer.arm.com/-/media/Files/downloads/mali-drivers/kernel/mali-midgard-gpu/TX011-SW-99002-r16p0-00rel0.tgz > > The following optional bindings have been omitted in this initial > version as they are only used in very specific cases: > > * snoop_enable_smc > * snoop_disable_smc > * jm_config > * power_model > * system-coherency > * ipa-model > > The example has been simplified accordingly. > > The compatible string definition has been limited to > "arm,mali-midgard" to avoid checkpatch.pl warnings and to match > what the driver actually expects (as of r16p0 out-of-tree). > > CC: John Reitan > Signed-off-by: Guillaume Tucker > --- > .../devicetree/bindings/gpu/arm,mali-midgard.txt | 53 ++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > new file mode 100644 > index 000000000000..da8fc6d21bbf > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -0,0 +1,53 @@ > +# > +# (C) COPYRIGHT 2013-2016 ARM Limited. > +# Copyright (C) 2017 Collabora Ltd > +# > +# This program is free software and is provided to you under the terms of the > +# GNU General Public License version 2 as published by the Free Software > +# Foundation, and any use by you of this program is subject to the terms > +# of such GNU licence. > +# > + > + > +ARM Mali Midgard GPU > +==================== > + > +Required properties: > + > +- compatible : Should be "arm,mali-midgard". As Neil said... > +- reg : Physical base address of the device and length of the register area. > +- interrupts : Contains the three IRQ lines required by Mali Midgard devices. > +- interrupt-names : Contains the names of IRQ resources in the order they were > + provided in the interrupts property. Must contain: "JOB, "MMU", "GPU". > + > +Optional: > + > +- clocks : Phandle to clock for the Mali Midgard device. > +- clock-names : Shall be "clk_mali". "clk_" is redundant. Actually, if there is only 1 clock, then just drop names. But there's not at least a core and bus clock? > +- mali-supply : Phandle to regulator for the Mali device. Refer to > + Documentation/devicetree/bindings/regulator/regulator.txt for details. > +- operating-points : Refer to Documentation/devicetree/bindings/power/opp.txt > + for details. Is this going to be sufficient vs. operating-points-v2? Or should it be a power domain with OPPs? > + > +Example for a Mali-T602: > + > +gpu@0xfc010000 { Drop the '0x'. > + compatible = "arm,mali-midgard"; > + reg = <0xfc010000 0x4000>; > + interrupts = <0 36 4>, <0 37 4>, <0 38 4>; > + interrupt-names = "JOB", "MMU", "GPU"; > + > + clocks = <&pclk_mali>; > + clock-names = "clk_mali"; > + mali-supply = <&vdd_mali>; > + operating-points = < > + /* KHz uV */ > + 533000 1250000, > + 450000 1150000, > + 400000 1125000, > + 350000 1075000, > + 266000 1025000, > + 160000 925000, > + 100000 912500, > + >; > +}; > -- > 2.11.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Mon, 3 Apr 2017 21:00:56 -0500 Subject: [PATCH v2 1/5] dt-bindings: gpu: add bindings for the ARM Mali Midgard GPU In-Reply-To: References: Message-ID: <20170404020056.d7osj7rmog22xbjd@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Apr 02, 2017 at 08:59:44AM +0100, Guillaume Tucker wrote: > The ARM Mali Midgard GPU family is present in a number of SoCs > from many different vendors such as Samsung Exynos and Rockchip. > > Import the device tree bindings documentation from the r16p0 > release of the Mali Midgard GPU kernel driver: > > https://developer.arm.com/-/media/Files/downloads/mali-drivers/kernel/mali-midgard-gpu/TX011-SW-99002-r16p0-00rel0.tgz > > The following optional bindings have been omitted in this initial > version as they are only used in very specific cases: > > * snoop_enable_smc > * snoop_disable_smc > * jm_config > * power_model > * system-coherency > * ipa-model > > The example has been simplified accordingly. > > The compatible string definition has been limited to > "arm,mali-midgard" to avoid checkpatch.pl warnings and to match > what the driver actually expects (as of r16p0 out-of-tree). > > CC: John Reitan > Signed-off-by: Guillaume Tucker > --- > .../devicetree/bindings/gpu/arm,mali-midgard.txt | 53 ++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > new file mode 100644 > index 000000000000..da8fc6d21bbf > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -0,0 +1,53 @@ > +# > +# (C) COPYRIGHT 2013-2016 ARM Limited. > +# Copyright (C) 2017 Collabora Ltd > +# > +# This program is free software and is provided to you under the terms of the > +# GNU General Public License version 2 as published by the Free Software > +# Foundation, and any use by you of this program is subject to the terms > +# of such GNU licence. > +# > + > + > +ARM Mali Midgard GPU > +==================== > + > +Required properties: > + > +- compatible : Should be "arm,mali-midgard". As Neil said... > +- reg : Physical base address of the device and length of the register area. > +- interrupts : Contains the three IRQ lines required by Mali Midgard devices. > +- interrupt-names : Contains the names of IRQ resources in the order they were > + provided in the interrupts property. Must contain: "JOB, "MMU", "GPU". > + > +Optional: > + > +- clocks : Phandle to clock for the Mali Midgard device. > +- clock-names : Shall be "clk_mali". "clk_" is redundant. Actually, if there is only 1 clock, then just drop names. But there's not at least a core and bus clock? > +- mali-supply : Phandle to regulator for the Mali device. Refer to > + Documentation/devicetree/bindings/regulator/regulator.txt for details. > +- operating-points : Refer to Documentation/devicetree/bindings/power/opp.txt > + for details. Is this going to be sufficient vs. operating-points-v2? Or should it be a power domain with OPPs? > + > +Example for a Mali-T602: > + > +gpu at 0xfc010000 { Drop the '0x'. > + compatible = "arm,mali-midgard"; > + reg = <0xfc010000 0x4000>; > + interrupts = <0 36 4>, <0 37 4>, <0 38 4>; > + interrupt-names = "JOB", "MMU", "GPU"; > + > + clocks = <&pclk_mali>; > + clock-names = "clk_mali"; > + mali-supply = <&vdd_mali>; > + operating-points = < > + /* KHz uV */ > + 533000 1250000, > + 450000 1150000, > + 400000 1125000, > + 350000 1075000, > + 266000 1025000, > + 160000 925000, > + 100000 912500, > + >; > +}; > -- > 2.11.0 >