From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751564AbdDDFkw (ORCPT ); Tue, 4 Apr 2017 01:40:52 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:53004 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbdDDFkv (ORCPT ); Tue, 4 Apr 2017 01:40:51 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.249.26 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Tue, 4 Apr 2017 14:40:48 +0900 From: Minchan Kim To: Sergey Senozhatsky CC: Andrew Morton , , Sergey Senozhatsky , Subject: Re: [PATCH 4/5] zram: remove zram_meta structure Message-ID: <20170404054048.GA10095@bbox> References: <1491196653-7388-1-git-send-email-minchan@kernel.org> <1491196653-7388-5-git-send-email-minchan@kernel.org> <20170404023115.GC475@jagdpanzerIV.localdomain> MIME-Version: 1.0 In-Reply-To: <20170404023115.GC475@jagdpanzerIV.localdomain> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/04/04 14:40:47, Serialize by Router on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/04/04 14:40:48, Serialize complete at 2017/04/04 14:40:48 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 04, 2017 at 11:31:15AM +0900, Sergey Senozhatsky wrote: < snip > > > [..] > > -struct zram_meta { > > +struct zram { > > struct zram_table_entry *table; > > struct zs_pool *mem_pool; > > -}; > > - > > -struct zram { > > - struct zram_meta *meta; > > struct zcomp *comp; > > struct gendisk *disk; > > /* Prevent concurrent execution of device init */ > > > we still have several zram_meta_FOO() left overs in zram_drv.c I intentionally used that term because I don't think better name to wrap logis which allocates table and mempool. Feel free to suggest if you have better. Thanks.