From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbdDDFyb (ORCPT ); Tue, 4 Apr 2017 01:54:31 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33616 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdDDFya (ORCPT ); Tue, 4 Apr 2017 01:54:30 -0400 Date: Tue, 4 Apr 2017 14:54:30 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, Sergey Senozhatsky , kernel-team@lge.com Subject: Re: [PATCH 4/5] zram: remove zram_meta structure Message-ID: <20170404055430.GB470@jagdpanzerIV.localdomain> References: <1491196653-7388-1-git-send-email-minchan@kernel.org> <1491196653-7388-5-git-send-email-minchan@kernel.org> <20170404023115.GC475@jagdpanzerIV.localdomain> <20170404054048.GA10095@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170404054048.GA10095@bbox> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (04/04/17 14:40), Minchan Kim wrote: > > [..] > > > -struct zram_meta { > > > +struct zram { > > > struct zram_table_entry *table; > > > struct zs_pool *mem_pool; > > > -}; > > > - > > > -struct zram { > > > - struct zram_meta *meta; > > > struct zcomp *comp; > > > struct gendisk *disk; > > > /* Prevent concurrent execution of device init */ > > > > > > we still have several zram_meta_FOO() left overs in zram_drv.c > > I intentionally used that term because I don't think better name > to wrap logis which allocates table and mempool. ah, it was intentional. um, OK, let's keep zram_meta_foo(). -ss