From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752829AbdDDHNP (ORCPT <rfc822;w@1wt.eu>);
        Tue, 4 Apr 2017 03:13:15 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:47586 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751156AbdDDHNN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Apr 2017 03:13:13 -0400
Date: Tue, 4 Apr 2017 09:13:02 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        RT-users <linux-rt-users@vger.kernel.org>,
        Sebastian Siewior <bigeasy@linutronix.de>,
        Julia Cartwright <julia@ni.com>, Wargreen <wargreen@lebib.org>,
        rt-stable@vger.kernel.org
Subject: Re: [patch RT 1/4] rtmutex: Make lock_killable work
Message-ID: <20170404071302.GB3093@worktop>
References: <20170401105058.958246042@linutronix.de>
 <20170401112758.051867031@linutronix.de>
 <20170403112126.75504264@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170403112126.75504264@gandalf.local.home>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 03, 2017 at 11:21:26AM -0400, Steven Rostedt wrote:
> On Sat, 01 Apr 2017 12:50:59 +0200
> Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > Locking an rt mutex killable does not work because signal handling is
> > restricted to TASK_INTERRUPTIBLE.
> > 
> > Use signal_pending_state() unconditionaly.
> 
> Does this mean rt mutex killable is not INTERRUPTIBLE? because the
> change log seems to just assume that.

> > -		if (unlikely(state == TASK_INTERRUPTIBLE)) {

#define TASK_KILLABLE           (TASK_WAKEKILL | TASK_UNINTERRUPTIBLE)


I don't think we need to consider people who don't know where to find
the TASK_state definitions.