Re: [PATCH v2] x86/monitor: add support for descriptor access events

From: Adrian Pop <apop@bitdefender.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Razvan Cojocaru <rcojocaru@bitdefender.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] x86/monitor: add support for descriptor access events
Date: Tue, 4 Apr 2017 16:45:39 +0300	[thread overview]
Message-ID: <20170404134539.GA32165@hel> (raw)
In-Reply-To: <2d6ca461-bff8-24c3-521f-ffcf009c0b60@oracle.com>

On Tue, Apr 04, 2017 at 09:23:28AM -0400, Boris Ostrovsky wrote:
> On 04/04/2017 05:57 AM, Adrian Pop wrote:
> > Adds monitor support for descriptor access events (reads & writes of
> > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM).
> >
> > Signed-off-by: Adrian Pop <apop@bitdefender.com>
> 
> 
> > --- a/xen/arch/x86/hvm/svm/svm.c
> > +++ b/xen/arch/x86/hvm/svm/svm.c
> > @@ -856,6 +856,23 @@ static void svm_set_rdtsc_exiting(struct vcpu *v, bool_t enable)
> >      vmcb_set_general2_intercepts(vmcb, general2_intercepts);
> >  }
> >  
> > +static void svm_set_descriptor_access_exiting(struct vcpu *v, bool enable)
> > +{
> > +    struct vmcb_struct *vmcb = v->arch.hvm_svm.vmcb;
> > +    u32 general1_intercepts = vmcb_get_general1_intercepts(vmcb);
> > +    u32 mask = GENERAL1_INTERCEPT_IDTR_READ | GENERAL1_INTERCEPT_GDTR_READ \
> > +            | GENERAL1_INTERCEPT_LDTR_READ | GENERAL1_INTERCEPT_TR_READ \
> > +            | GENERAL1_INTERCEPT_IDTR_WRITE | GENERAL1_INTERCEPT_GDTR_WRITE \
> > +            | GENERAL1_INTERCEPT_LDTR_WRITE | GENERAL1_INTERCEPT_TR_WRITE;
> 
> I didn't notice this last time --- there is no need for line
> continuation here.
> 
> With that fixed,
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Oh, yes.  I'll remove the escapes for the next version.  Thank you!

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel