From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753743AbdDDN4g convert rfc822-to-8bit (ORCPT ); Tue, 4 Apr 2017 09:56:36 -0400 Received: from muru.com ([72.249.23.125]:43262 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752205AbdDDN4f (ORCPT ); Tue, 4 Apr 2017 09:56:35 -0400 Date: Tue, 4 Apr 2017 06:56:30 -0700 From: Tony Lindgren To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Charles Keepax , Lee Jones , Marcel Partap , Michael Scott Subject: Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread Message-ID: <20170404135629.GN10760@atomide.com> References: <20170322171052.7006-1-tony@atomide.com> <20170322171052.7006-2-tony@atomide.com> <20170327174952.jsfleql654m2h45i@sirena.org.uk> <20170328003648.GS10760@atomide.com> <20170328151849.uvj2ljkbts4cwksq@sirena.org.uk> <20170328154740.GW10760@atomide.com> <20170328164911.xwwl3kdy6j2y7hfq@sirena.org.uk> <20170328171022.GZ10760@atomide.com> <20170404030300.GK10760@atomide.com> <20170404121957.v64jcx2k4w3mwtje@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20170404121957.v64jcx2k4w3mwtje@sirena.org.uk> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mark Brown [170404 05:22]: > On Mon, Apr 03, 2017 at 08:03:00PM -0700, Tony Lindgren wrote: > > > So I'll drop the genirq/regmap_irq related hacks and resend just > > the minimal MFD fixes. Similar misconfiguration may be the root > > cause for other drivers too.. > > It is sadly far too common for people to implement interrupt controllers > that only do edge triggers, I've no idea why even on what are supposed > to be relatively high end SoCs. It seems to be a hardware designer > thing, AFAICT they think for something to be useful it needs to be a bit > more complicated. For edge only GPIO controllers handling level interrupts might be somewhat fixable in software. The GPIO controller could have a loop reading of the GPIO line status in the interrupt handler and comparing it to the configured triggering. Regards, Tony