From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754019AbdDDNPj (ORCPT ); Tue, 4 Apr 2017 09:15:39 -0400 Received: from dougal.metanate.com ([90.155.101.14]:53324 "EHLO metanate.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753101AbdDDNPh (ORCPT ); Tue, 4 Apr 2017 09:15:37 -0400 Date: Tue, 4 Apr 2017 14:15:13 +0100 From: John Keeping To: Sean Paul Cc: Rob Herring , Brian Norris , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Message-ID: <20170404141513.2bad3b1b.john@metanate.com> In-Reply-To: <20170312120659.hpiwnsto6hkxs5yh@rob-hp-laptop> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> <20170312120659.hpiwnsto6hkxs5yh@rob-hp-laptop> Organization: Metanate Ltd X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean, On Sun, 12 Mar 2017 07:06:59 -0500, Rob Herring wrote: > On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote: > > This reset is required in order to fully reset the internal state of the > > MIPI controller. > > > > Signed-off-by: John Keeping > > --- > > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > > > + /* > > > > + * Note that the reset was not defined in the initial device tree, so > > > > + * we have to be prepared for it not being found. > > > > + */ > > > > + apb_rst = devm_reset_control_get(dev, "apb"); > > > > > > Did this reset ever get documented in the device tree bindings? I > > > couldn't find it. Perhaps a follow-up patch is in order? > > > > Here's a patch to do that. > > > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +++++++ > > 1 file changed, 7 insertions(+) > > Acked-by: Rob Herring I don't see this patch in linux-next, so I guess it has fallen through the cracks somewhere. Since we have Rob's ack, can you pick this via drm-misc? Regards, John From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Keeping Subject: Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Date: Tue, 4 Apr 2017 14:15:13 +0100 Message-ID: <20170404141513.2bad3b1b.john@metanate.com> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> <20170312120659.hpiwnsto6hkxs5yh@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170312120659.hpiwnsto6hkxs5yh@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sean Paul Cc: Rob Herring , Brian Norris , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Chris Zhong , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Sean, On Sun, 12 Mar 2017 07:06:59 -0500, Rob Herring wrote: > On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote: > > This reset is required in order to fully reset the internal state of the > > MIPI controller. > > > > Signed-off-by: John Keeping > > --- > > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > > > + /* > > > > + * Note that the reset was not defined in the initial device tree, so > > > > + * we have to be prepared for it not being found. > > > > + */ > > > > + apb_rst = devm_reset_control_get(dev, "apb"); > > > > > > Did this reset ever get documented in the device tree bindings? I > > > couldn't find it. Perhaps a follow-up patch is in order? > > > > Here's a patch to do that. > > > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +++++++ > > 1 file changed, 7 insertions(+) > > Acked-by: Rob Herring I don't see this patch in linux-next, so I guess it has fallen through the cracks somewhere. Since we have Rob's ack, can you pick this via drm-misc? Regards, John -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: john@metanate.com (John Keeping) Date: Tue, 4 Apr 2017 14:15:13 +0100 Subject: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property In-Reply-To: <20170312120659.hpiwnsto6hkxs5yh@rob-hp-laptop> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> <20170312120659.hpiwnsto6hkxs5yh@rob-hp-laptop> Message-ID: <20170404141513.2bad3b1b.john@metanate.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sean, On Sun, 12 Mar 2017 07:06:59 -0500, Rob Herring wrote: > On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote: > > This reset is required in order to fully reset the internal state of the > > MIPI controller. > > > > Signed-off-by: John Keeping > > --- > > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > > > + /* > > > > + * Note that the reset was not defined in the initial device tree, so > > > > + * we have to be prepared for it not being found. > > > > + */ > > > > + apb_rst = devm_reset_control_get(dev, "apb"); > > > > > > Did this reset ever get documented in the device tree bindings? I > > > couldn't find it. Perhaps a follow-up patch is in order? > > > > Here's a patch to do that. > > > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +++++++ > > 1 file changed, 7 insertions(+) > > Acked-by: Rob Herring I don't see this patch in linux-next, so I guess it has fallen through the cracks somewhere. Since we have Rob's ack, can you pick this via drm-misc? Regards, John