From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754136AbdDDOrU (ORCPT ); Tue, 4 Apr 2017 10:47:20 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33080 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753141AbdDDOrR (ORCPT ); Tue, 4 Apr 2017 10:47:17 -0400 Date: Tue, 4 Apr 2017 09:47:15 -0500 From: Rob Herring To: Icenowy Zheng Cc: Lee Jones , Maxime Ripard , Chen-Yu Tsai , Jonathan Cameron , Quentin Schulz , Zhang Rui , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3 Message-ID: <20170404144715.fa5sy427u2cz4e6z@rob-hp-laptop> References: <20170402133304.56824-1-icenowy@aosc.io> <20170402133304.56824-2-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170402133304.56824-2-icenowy@aosc.io> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote: > Allwinner H3 features a thermal sensor like the one in A33, but has its > register re-arranged, the clock divider moved to CCU (originally the > clock divider is in ADC) and added a pair of bus clock and reset. > > Update the binding document to cover H3. > > Signed-off-by: Icenowy Zheng > --- > .../devicetree/bindings/mfd/sun4i-gpadc.txt | 23 ++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > index badff3611a98..7753133ca0ff 100644 > --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor > and sometimes as a touchscreen controller. > > Required properties: > - - compatible: "allwinner,sun8i-a33-ths", > + - compatible: must contain one of the following compatibles: > + - "allwinner,sun8i-a33-ths" > + - "allwinner,sun8i-h3-ths" > - reg: mmio address range of the chip, > - #thermal-sensor-cells: shall be 0, > - #io-channel-cells: shall be 0, > > -Example: > +Required properties for the following compatibles: > + - "allwinner,sun8i-h3-ths" > + - clocks: the bus clock and the input clock of the ADC, > + - clock-names: should be "bus" and "ths", > + - resets: the bus reset of the ADC, > + > +Example for A33: > ths: ths@01c25000 { > compatible = "allwinner,sun8i-a33-ths"; > reg = <0x01c25000 0x100>; > @@ -17,6 +25,17 @@ Example: > #io-channel-cells = <0>; > }; > > +Example for H3: > + ths: ths@01c25000 { adc@... And drop the leading 0. > + compatible = "allwinner,sun8i-h3-ths"; > + reg = <0x01c25000 0x100>; > + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>; > + clock-names = "bus", "ths"; > + resets = <&ccu RST_BUS_THS>; > + #thermal-sensor-cells = <0>; > + #io-channel-cells = <0>; > + }; > + > sun4i, sun5i and sun6i SoCs are also supported via the older binding: > > sun4i resistive touchscreen controller > -- > 2.12.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3 Date: Tue, 4 Apr 2017 09:47:15 -0500 Message-ID: <20170404144715.fa5sy427u2cz4e6z@rob-hp-laptop> References: <20170402133304.56824-1-icenowy@aosc.io> <20170402133304.56824-2-icenowy@aosc.io> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170402133304.56824-2-icenowy-h8G6r0blFSE@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Icenowy Zheng Cc: Lee Jones , Maxime Ripard , Chen-Yu Tsai , Jonathan Cameron , Quentin Schulz , Zhang Rui , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote: > Allwinner H3 features a thermal sensor like the one in A33, but has its > register re-arranged, the clock divider moved to CCU (originally the > clock divider is in ADC) and added a pair of bus clock and reset. > > Update the binding document to cover H3. > > Signed-off-by: Icenowy Zheng > --- > .../devicetree/bindings/mfd/sun4i-gpadc.txt | 23 ++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > index badff3611a98..7753133ca0ff 100644 > --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor > and sometimes as a touchscreen controller. > > Required properties: > - - compatible: "allwinner,sun8i-a33-ths", > + - compatible: must contain one of the following compatibles: > + - "allwinner,sun8i-a33-ths" > + - "allwinner,sun8i-h3-ths" > - reg: mmio address range of the chip, > - #thermal-sensor-cells: shall be 0, > - #io-channel-cells: shall be 0, > > -Example: > +Required properties for the following compatibles: > + - "allwinner,sun8i-h3-ths" > + - clocks: the bus clock and the input clock of the ADC, > + - clock-names: should be "bus" and "ths", > + - resets: the bus reset of the ADC, > + > +Example for A33: > ths: ths@01c25000 { > compatible = "allwinner,sun8i-a33-ths"; > reg = <0x01c25000 0x100>; > @@ -17,6 +25,17 @@ Example: > #io-channel-cells = <0>; > }; > > +Example for H3: > + ths: ths@01c25000 { adc@... And drop the leading 0. > + compatible = "allwinner,sun8i-h3-ths"; > + reg = <0x01c25000 0x100>; > + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>; > + clock-names = "bus", "ths"; > + resets = <&ccu RST_BUS_THS>; > + #thermal-sensor-cells = <0>; > + #io-channel-cells = <0>; > + }; > + > sun4i, sun5i and sun6i SoCs are also supported via the older binding: > > sun4i resistive touchscreen controller > -- > 2.12.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Tue, 4 Apr 2017 09:47:15 -0500 Subject: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3 In-Reply-To: <20170402133304.56824-2-icenowy@aosc.io> References: <20170402133304.56824-1-icenowy@aosc.io> <20170402133304.56824-2-icenowy@aosc.io> Message-ID: <20170404144715.fa5sy427u2cz4e6z@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote: > Allwinner H3 features a thermal sensor like the one in A33, but has its > register re-arranged, the clock divider moved to CCU (originally the > clock divider is in ADC) and added a pair of bus clock and reset. > > Update the binding document to cover H3. > > Signed-off-by: Icenowy Zheng > --- > .../devicetree/bindings/mfd/sun4i-gpadc.txt | 23 ++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > index badff3611a98..7753133ca0ff 100644 > --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor > and sometimes as a touchscreen controller. > > Required properties: > - - compatible: "allwinner,sun8i-a33-ths", > + - compatible: must contain one of the following compatibles: > + - "allwinner,sun8i-a33-ths" > + - "allwinner,sun8i-h3-ths" > - reg: mmio address range of the chip, > - #thermal-sensor-cells: shall be 0, > - #io-channel-cells: shall be 0, > > -Example: > +Required properties for the following compatibles: > + - "allwinner,sun8i-h3-ths" > + - clocks: the bus clock and the input clock of the ADC, > + - clock-names: should be "bus" and "ths", > + - resets: the bus reset of the ADC, > + > +Example for A33: > ths: ths at 01c25000 { > compatible = "allwinner,sun8i-a33-ths"; > reg = <0x01c25000 0x100>; > @@ -17,6 +25,17 @@ Example: > #io-channel-cells = <0>; > }; > > +Example for H3: > + ths: ths at 01c25000 { adc at ... And drop the leading 0. > + compatible = "allwinner,sun8i-h3-ths"; > + reg = <0x01c25000 0x100>; > + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>; > + clock-names = "bus", "ths"; > + resets = <&ccu RST_BUS_THS>; > + #thermal-sensor-cells = <0>; > + #io-channel-cells = <0>; > + }; > + > sun4i, sun5i and sun6i SoCs are also supported via the older binding: > > sun4i resistive touchscreen controller > -- > 2.12.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel