From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754509AbdDDRPp (ORCPT ); Tue, 4 Apr 2017 13:15:45 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:39889 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753477AbdDDRPo (ORCPT ); Tue, 4 Apr 2017 13:15:44 -0400 Date: Tue, 4 Apr 2017 11:15:33 -0600 From: Jason Gunthorpe To: Paul Menzel Cc: tpmdd-devel@lists.sourceforge.net, Linux Kernel Mailing List Subject: Re: [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot Message-ID: <20170404171533.GA3255@obsidianresearch.com> References: <31e0ed69-174b-93ce-abf2-66cf08b1594e@molgen.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <31e0ed69-174b-93ce-abf2-66cf08b1594e@molgen.mpg.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 04, 2017 at 06:29:06PM +0200, Paul Menzel wrote: > Unfortunately, there seems to have been a regression between Linux 3.16 > and 4.8 and 4.9, so that the Linux kernel doesn’t create the TPM > device. That old kernel did not check error codes when reading burst count, the new one does. It is quite possible the older kernel is failing to read burst count and subtly malfunctioning. It would be helpful if you could prove/disprove this statement by adding some debugging to 3.16. As to why the burst count cannot be read.. I don't know, check if increasing the retries helps, it could be this particular TPM is out of spec for the cold startup process. > Remove module and run `sudo modprobe tpm_tis itpm=1 force=1`. Is this really an 'itpm'? It doesn't look like it.. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot Date: Tue, 4 Apr 2017 11:15:33 -0600 Message-ID: <20170404171533.GA3255@obsidianresearch.com> References: <31e0ed69-174b-93ce-abf2-66cf08b1594e@molgen.mpg.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <31e0ed69-174b-93ce-abf2-66cf08b1594e-KUpvgZVWgV9o1qOY/usvUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Paul Menzel Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Linux Kernel Mailing List List-Id: tpmdd-devel@lists.sourceforge.net T24gVHVlLCBBcHIgMDQsIDIwMTcgYXQgMDY6Mjk6MDZQTSArMDIwMCwgUGF1bCBNZW56ZWwgd3Jv dGU6Cgo+IFVuZm9ydHVuYXRlbHksIHRoZXJlIHNlZW1zIHRvIGhhdmUgYmVlbiBhIHJlZ3Jlc3Np b24gYmV0d2VlbiBMaW51eCAzLjE2IAo+IGFuZCA0LjggYW5kIDQuOSwgc28gdGhhdCB0aGUgTGlu dXgga2VybmVsIGRvZXNu4oCZdCBjcmVhdGUgdGhlIFRQTQo+IGRldmljZS4KClRoYXQgb2xkIGtl cm5lbCBkaWQgbm90IGNoZWNrIGVycm9yIGNvZGVzIHdoZW4gcmVhZGluZyBidXJzdCBjb3VudCwK dGhlIG5ldyBvbmUgZG9lcy4gSXQgaXMgcXVpdGUgcG9zc2libGUgdGhlIG9sZGVyIGtlcm5lbCBp cyBmYWlsaW5nIHRvCnJlYWQgYnVyc3QgY291bnQgYW5kIHN1YnRseSBtYWxmdW5jdGlvbmluZy4K Ckl0IHdvdWxkIGJlIGhlbHBmdWwgaWYgeW91IGNvdWxkIHByb3ZlL2Rpc3Byb3ZlIHRoaXMgc3Rh dGVtZW50IGJ5CmFkZGluZyBzb21lIGRlYnVnZ2luZyB0byAzLjE2LgoKQXMgdG8gd2h5IHRoZSBi dXJzdCBjb3VudCBjYW5ub3QgYmUgcmVhZC4uIEkgZG9uJ3Qga25vdywgY2hlY2sgaWYKaW5jcmVh c2luZyB0aGUgcmV0cmllcyBoZWxwcywgaXQgY291bGQgYmUgdGhpcyBwYXJ0aWN1bGFyIFRQTSBp cyBvdXQKb2Ygc3BlYyBmb3IgdGhlIGNvbGQgc3RhcnR1cCBwcm9jZXNzLgoKPiBSZW1vdmUgbW9k dWxlIGFuZCBydW4gYHN1ZG8gbW9kcHJvYmUgdHBtX3RpcyBpdHBtPTEgZm9yY2U9MWAuCgpJcyB0 aGlzIHJlYWxseSBhbiAnaXRwbSc/IEl0IGRvZXNuJ3QgbG9vayBsaWtlIGl0Li4KCkphc29uCgot LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KQ2hlY2sgb3V0IHRoZSB2aWJyYW50IHRlY2ggY29tbXVuaXR5 IG9uIG9uZSBvZiB0aGUgd29ybGQncyBtb3N0CmVuZ2FnaW5nIHRlY2ggc2l0ZXMsIFNsYXNoZG90 Lm9yZyEgaHR0cDovL3NkbS5saW5rL3NsYXNoZG90Cl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCnRwbWRkLWRldmVsIG1haWxpbmcgbGlzdAp0cG1kZC1kZXZl bEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlz dHMvbGlzdGluZm8vdHBtZGQtZGV2ZWwK