From: Sean Paul <seanpaul@chromium.org>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Xin Zhou <zhou.xin8@zte.com.cn>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Baoyou Xie <xie.baoyou@zte.com.cn>,
dri-devel@lists.freedesktop.org, Jun Nie <jun.nie@linaro.org>
Subject: Re: [PATCH 1/4] drm: zte: do not enable clock auto-gating by default
Date: Tue, 4 Apr 2017 13:48:09 -0400 [thread overview]
Message-ID: <20170404174809.hhlbzo2tzczkoucg@art_vandelay> (raw)
In-Reply-To: <1490098556-23853-2-git-send-email-shawnguo@kernel.org>
On Tue, Mar 21, 2017 at 08:15:53PM +0800, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo@linaro.org>
>
> Some VOU modules do not work well with clock auto-gating. For example,
> VGA I2C bus will fail to read EDID data from monitor. Let's not enable
> this feature by default, and leave it to the possible future low-power
> optimization.
>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/gpu/drm/zte/zx_vou.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c
> index cf92d675feaa..2a2d90bd9425 100644
> --- a/drivers/gpu/drm/zte/zx_vou.c
> +++ b/drivers/gpu/drm/zte/zx_vou.c
> @@ -720,9 +720,6 @@ static void vou_hw_init(struct zx_vou_hw *vou)
> /* Release reset for all VOU modules */
> zx_writel(vou->vouctl + VOU_SOFT_RST, ~0);
>
> - /* Enable clock auto-gating for all VOU modules */
> - zx_writel(vou->vouctl + VOU_CLK_REQEN, ~0);
> -
> /* Enable all VOU module clocks */
> zx_writel(vou->vouctl + VOU_CLK_EN, ~0);
>
> --
> 1.9.1
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-04-04 17:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 12:15 [PATCH 0/4] Add ZTE VGA driver support Shawn Guo
2017-03-21 12:15 ` [PATCH 1/4] drm: zte: do not enable clock auto-gating by default Shawn Guo
2017-04-04 17:48 ` Sean Paul [this message]
2017-03-21 12:15 ` [PATCH 2/4] drm: zte: move CSC register definitions into a common header Shawn Guo
2017-04-04 17:47 ` Sean Paul
2017-03-21 12:15 ` [PATCH 3/4] dt: add bindings for ZTE VGA device Shawn Guo
2017-03-21 12:15 ` [PATCH 4/4] drm: zte: add VGA driver support Shawn Guo
2017-04-03 9:23 ` Daniel Vetter
2017-04-04 13:47 ` Shawn Guo
2017-04-04 17:32 ` Sean Paul
2017-04-05 6:08 ` Shawn Guo
2017-04-05 6:25 ` Daniel Vetter
2017-04-04 17:46 ` Sean Paul
2017-04-05 14:08 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404174809.hhlbzo2tzczkoucg@art_vandelay \
--to=seanpaul@chromium.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jun.nie@linaro.org \
--cc=shawnguo@kernel.org \
--cc=xie.baoyou@zte.com.cn \
--cc=zhou.xin8@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.