All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers/staging/lustre: Replacing 'unsigned' with 'unsigned int'
@ 2017-04-04  9:44 Pushkar Jambhlekar
  2017-04-04 18:29   ` [lustre-devel] " Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Pushkar Jambhlekar @ 2017-04-04  9:44 UTC (permalink / raw)
  To: Oleg Drokin, Andreas Dilger, James Simmons, Greg Kroah-Hartman,
	John L. Hammond, Al Viro, Lai Siyao, Pushkar Jambhlekar,
	James Nunez, Andrew Perepechko, wang di, Bob Glossman,
	Andreas Gruenbacher, Jinshan Xiong, Bobi Jam, Kirill A. Shutemov,
	Henri Doreau, Prakash Surya, Emoly Liu, Dmitry Eremin,
	Johann Lombardi
  Cc: lustre-devel, devel, linux-kernel

Replacing 'unsigned' with 'unsigned int'

Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
 drivers/staging/lustre/lustre/llite/namei.c             | 2 +-
 drivers/staging/lustre/lustre/llite/rw26.c              | 2 +-
 drivers/staging/lustre/lustre/llite/vvp_dev.c           | 6 +++---
 drivers/staging/lustre/lustre/llite/vvp_io.c            | 2 +-
 drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
 drivers/staging/lustre/lustre/obdclass/lu_object.c      | 8 ++++----
 drivers/staging/lustre/lustre/osc/osc_cache.c           | 4 ++--
 7 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
index d583696..c1a69af 100644
--- a/drivers/staging/lustre/lustre/llite/namei.c
+++ b/drivers/staging/lustre/lustre/llite/namei.c
@@ -678,7 +678,7 @@ static struct dentry *ll_lookup_nd(struct inode *parent, struct dentry *dentry,
  * together.
  */
 static int ll_atomic_open(struct inode *dir, struct dentry *dentry,
-			  struct file *file, unsigned open_flags,
+			  struct file *file, unsigned int open_flags,
 			  umode_t mode, int *opened)
 {
 	struct lookup_intent *it;
diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c
index 420f296..03e9391 100644
--- a/drivers/staging/lustre/lustre/llite/rw26.c
+++ b/drivers/staging/lustre/lustre/llite/rw26.c
@@ -547,7 +547,7 @@ static int ll_write_begin(struct file *file, struct address_space *mapping,
 }
 
 static int ll_write_end(struct file *file, struct address_space *mapping,
-			loff_t pos, unsigned len, unsigned copied,
+			loff_t pos, unsigned int len, unsigned int copied,
 			struct page *vmpage, void *fsdata)
 {
 	struct ll_cl_context *lcc = fsdata;
diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/drivers/staging/lustre/lustre/llite/vvp_dev.c
index 6cb2db2..8e45672 100644
--- a/drivers/staging/lustre/lustre/llite/vvp_dev.c
+++ b/drivers/staging/lustre/lustre/llite/vvp_dev.c
@@ -381,11 +381,11 @@ int cl_sb_fini(struct super_block *sb)
 #define PGC_DEPTH_SHIFT (32)
 
 struct vvp_pgcache_id {
-	unsigned		 vpi_bucket;
-	unsigned		 vpi_depth;
+	unsigned int		 vpi_bucket;
+	unsigned int		 vpi_depth;
 	uint32_t		 vpi_index;
 
-	unsigned		 vpi_curdep;
+	unsigned int		 vpi_curdep;
 	struct lu_object_header *vpi_obj;
 };
 
diff --git a/drivers/staging/lustre/lustre/llite/vvp_io.c b/drivers/staging/lustre/lustre/llite/vvp_io.c
index aa31bc0..49a7bcf 100644
--- a/drivers/staging/lustre/lustre/llite/vvp_io.c
+++ b/drivers/staging/lustre/lustre/llite/vvp_io.c
@@ -598,7 +598,7 @@ static int vvp_io_setattr_time(const struct lu_env *env,
 	struct cl_object   *obj   = io->ci_obj;
 	struct cl_attr     *attr  = vvp_env_thread_attr(env);
 	int result;
-	unsigned valid = CAT_CTIME;
+	unsigned int valid = CAT_CTIME;
 
 	cl_object_attr_lock(obj);
 	attr->cat_ctime = io->u.ci_setattr.sa_attr.lvb_ctime;
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 1ec6e37..38145fd 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -1501,7 +1501,7 @@ int lprocfs_write_frac_u64_helper(const char __user *buffer,
 {
 	char kernbuf[22], *end, *pbuf;
 	__u64 whole, frac = 0, units;
-	unsigned frac_d = 1;
+	unsigned int frac_d = 1;
 	int sign = 1;
 
 	if (count > (sizeof(kernbuf) - 1))
diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_object.c
index abcf951..31d38cf 100644
--- a/drivers/staging/lustre/lustre/obdclass/lu_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c
@@ -1796,10 +1796,10 @@ int lu_env_refill(struct lu_env *env)
 EXPORT_SYMBOL(lu_env_refill);
 
 struct lu_site_stats {
-	unsigned	lss_populated;
-	unsigned	lss_max_search;
-	unsigned	lss_total;
-	unsigned	lss_busy;
+	unsigned int	lss_populated;
+	unsigned int	lss_max_search;
+	unsigned int	lss_total;
+	unsigned int	lss_busy;
 };
 
 static void lu_site_stats_get(struct cfs_hash *hs,
diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c b/drivers/staging/lustre/lustre/osc/osc_cache.c
index c5ccf56..d7ed6da 100644
--- a/drivers/staging/lustre/lustre/osc/osc_cache.c
+++ b/drivers/staging/lustre/lustre/osc/osc_cache.c
@@ -1893,7 +1893,7 @@ struct extent_rpc_data {
 static inline unsigned osc_extent_chunks(const struct osc_extent *ext)
 {
 	struct client_obd *cli = osc_cli(ext->oe_obj);
-	unsigned ppc_bits = cli->cl_chunkbits - PAGE_SHIFT;
+	unsigned int ppc_bits = cli->cl_chunkbits - PAGE_SHIFT;
 
 	return (ext->oe_end >> ppc_bits) - (ext->oe_start >> ppc_bits) + 1;
 }
@@ -1951,7 +1951,7 @@ static int try_to_add_extent_for_io(struct client_obd *cli,
 	return 1;
 }
 
-static inline unsigned osc_max_write_chunks(const struct client_obd *cli)
+static inline unsigned int osc_max_write_chunks(const struct client_obd *cli)
 {
 	/*
 	 * LU-8135:
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers/staging/lustre: Replacing 'unsigned' with 'unsigned int'
  2017-04-04  9:44 [PATCH] drivers/staging/lustre: Replacing 'unsigned' with 'unsigned int' Pushkar Jambhlekar
@ 2017-04-04 18:29   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2017-04-04 18:29 UTC (permalink / raw)
  To: Pushkar Jambhlekar
  Cc: Oleg Drokin, Andreas Dilger, James Simmons, John L. Hammond,
	Al Viro, Lai Siyao, James Nunez, Andrew Perepechko, wang di,
	Bob Glossman, Andreas Gruenbacher, Jinshan Xiong, Bobi Jam,
	Kirill A. Shutemov, Henri Doreau, Prakash Surya, Emoly Liu,
	Dmitry Eremin, Johann Lombardi, devel, linux-kernel,
	lustre-devel

On Tue, Apr 04, 2017 at 03:14:03PM +0530, Pushkar Jambhlekar wrote:
> Replacing 'unsigned' with 'unsigned int'

Why?  You need to explain why you do something, not just say what you
did (that should be obvious if you read the patch...)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [lustre-devel] [PATCH] drivers/staging/lustre: Replacing 'unsigned' with 'unsigned int'
@ 2017-04-04 18:29   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2017-04-04 18:29 UTC (permalink / raw)
  To: Pushkar Jambhlekar
  Cc: Oleg Drokin, Andreas Dilger, James Simmons, John L. Hammond,
	Al Viro, Lai Siyao, James Nunez, Andrew Perepechko, wang di,
	Bob Glossman, Andreas Gruenbacher, Jinshan Xiong, Bobi Jam,
	Kirill A. Shutemov, Henri Doreau, Prakash Surya, Emoly Liu,
	Dmitry Eremin, Johann Lombardi, devel, linux-kernel,
	lustre-devel

On Tue, Apr 04, 2017 at 03:14:03PM +0530, Pushkar Jambhlekar wrote:
> Replacing 'unsigned' with 'unsigned int'

Why?  You need to explain why you do something, not just say what you
did (that should be obvious if you read the patch...)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-04 18:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04  9:44 [PATCH] drivers/staging/lustre: Replacing 'unsigned' with 'unsigned int' Pushkar Jambhlekar
2017-04-04 18:29 ` Greg Kroah-Hartman
2017-04-04 18:29   ` [lustre-devel] " Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.