From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvV1F-0002LC-1C for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:25:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvV1E-0003D3-13 for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:25:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34880) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvV1D-0003Co-BU for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:25:35 -0400 From: Eduardo Habkost Date: Tue, 4 Apr 2017 17:24:21 -0300 Message-Id: <20170404202429.14643-14-ehabkost@redhat.com> In-Reply-To: <20170404202429.14643-1-ehabkost@redhat.com> References: <20170404202429.14643-1-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 13/21] unimplemented-device: Remove user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laszlo Ersek , Thomas Huth , Alexander Graf , Peter Maydell , Marcel Apfelbaum , Markus Armbruster unimplemented-device needs to be created and mapped using create_unimplemented_device() (or equivalent code), and won't work with -device. Remove the user_creatable flag from the device class. Cc: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Commit message rewrite only --- hw/misc/unimp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index e446c1d652..bcbb585888 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -90,11 +90,6 @@ static void unimp_class_init(ObjectClass *klass, void = *data) =20 dc->realize =3D unimp_realize; dc->props =3D unimp_properties; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable =3D true; } =20 static const TypeInfo unimp_info =3D { --=20 2.11.0.259.g40922b1