From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvV0d-0001iy-HN for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:25:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvV0c-0002rl-MG for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:24:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39576) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvV0c-0002rT-Gv for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:24:58 -0400 From: Eduardo Habkost Date: Tue, 4 Apr 2017 17:24:12 -0300 Message-Id: <20170404202429.14643-5-ehabkost@redhat.com> In-Reply-To: <20170404202429.14643-1-ehabkost@redhat.com> References: <20170404202429.14643-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH v2 04/21] iommu: Remove FIXME comment about user_creatable=true List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laszlo Ersek , Thomas Huth , Alexander Graf , Peter Maydell , Marcel Apfelbaum , Markus Armbruster , "Michael S. Tsirkin" amd-iommu and intel-iommu are really meant to be used with -device, so they need user_creatable=true. Remove the FIXME comment. Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * (none) --- hw/i386/amd_iommu.c | 5 +---- hw/i386/intel_iommu.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 7b92c8c15a..efcc93cbfd 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -1186,10 +1186,7 @@ static void amdvi_class_init(ObjectClass *klass, void* data) dc->vmsd = &vmstate_amdvi; dc->hotpluggable = false; dc_class->realize = amdvi_realize; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ + /* Supported by the pc-q35-* machine types */ dc->user_creatable = true; } diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index d71d52c328..b14db306ef 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2601,10 +2601,7 @@ static void vtd_class_init(ObjectClass *klass, void *data) dc->hotpluggable = false; x86_class->realize = vtd_realize; x86_class->int_remap = vtd_int_remap; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ + /* Supported by the pc-q35-* machine types */ dc->user_creatable = true; } -- 2.11.0.259.g40922b1